Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 8dc0814

Browse filesBrowse files
fabpotfabpot
committed
bug #32437 Fix toolbar load when GET params are present in "_wdt" route (Molkobain)
This PR was merged into the 3.4 branch. Discussion ---------- Fix toolbar load when GET params are present in "_wdt" route When using a custom router that inject GET parameters, eg: ``` # services.yaml parameters: # Replace default url generator service router.options.generator_base_class: Combodo\iTop\Portal\Routing\UrlGenerator ``` The path generated by the toolbar JS is HTML entity encoded which breaks the JS call (`&` becomes `&amp;`). | Q | A | ------------- | --- | Branch? | 4.4 for features / 3.4, 4.2 or 4.3 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 5309e64 Fix toolbar load when GET params are present in "_wdt" route
2 parents 650f179 + 5309e64 commit 8dc0814
Copy full SHA for 8dc0814

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_js.html.twig
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
1616
Sfjs.load(
1717
'sfwdt{{ token }}',
18-
'{{ path("_wdt", { "token": token }) }}',
18+
'{{ path("_wdt", { "token": token })|escape('js') }}',
1919
function(xhr, el) {
2020
2121
/* Evaluate embedded scripts inside the toolbar */

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.