Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8bee688

Browse filesBrowse files
committed
fixed a test
1 parent d221a69 commit 8bee688
Copy full SHA for 8bee688

File tree

Expand file treeCollapse file tree

2 files changed

+11
-13
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+11
-13
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/Templating/Helper/SessionHelperTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Templating/Helper/SessionHelperTest.php
+10-12Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,34 +11,32 @@
1111

1212
namespace Symfony\Bundle\FrameworkBundle\Tests\Templating\Helper;
1313

14+
use Symfony\Component\HttpFoundation\RequestStack;
1415
use Symfony\Component\HttpFoundation\Request;
1516
use Symfony\Component\HttpFoundation\Session\Session;
1617
use Symfony\Component\HttpFoundation\Session\Storage\MockArraySessionStorage;
1718
use Symfony\Bundle\FrameworkBundle\Templating\Helper\SessionHelper;
1819

1920
class SessionHelperTest extends \PHPUnit_Framework_TestCase
2021
{
21-
protected $request;
22+
protected $requestStack;
2223

2324
protected function setUp()
2425
{
25-
$this->request = new Request();
26+
$this->requestStack = new RequestStack();
2627

2728
$session = new Session(new MockArraySessionStorage());
2829
$session->set('foobar', 'bar');
2930
$session->getFlashBag()->set('notice', 'bar');
3031

31-
$this->request->setSession($session);
32-
}
33-
34-
protected function tearDown()
35-
{
36-
$this->request = null;
32+
$request = new Request();
33+
$request->setSession($session);
34+
$this->requestStack->push($request);
3735
}
3836

3937
public function testFlash()
4038
{
41-
$helper = new SessionHelper($this->request);
39+
$helper = new SessionHelper($this->requestStack);
4240

4341
$this->assertTrue($helper->hasFlash('notice'));
4442

@@ -47,13 +45,13 @@ public function testFlash()
4745

4846
public function testGetFlashes()
4947
{
50-
$helper = new SessionHelper($this->request);
48+
$helper = new SessionHelper($this->requestStack);
5149
$this->assertEquals(array('notice' => array('bar')), $helper->getFlashes());
5250
}
5351

5452
public function testGet()
5553
{
56-
$helper = new SessionHelper($this->request);
54+
$helper = new SessionHelper($this->requestStack);
5755

5856
$this->assertEquals('bar', $helper->get('foobar'));
5957
$this->assertEquals('foo', $helper->get('bar', 'foo'));
@@ -63,7 +61,7 @@ public function testGet()
6361

6462
public function testGetName()
6563
{
66-
$helper = new SessionHelper($this->request);
64+
$helper = new SessionHelper($this->requestStack);
6765

6866
$this->assertEquals('session', $helper->getName());
6967
}

‎src/Symfony/Component/Console/Tests/ApplicationTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Tests/ApplicationTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public function testAdd()
127127
}
128128

129129
/**
130-
* @expectedException InvalidArgumentException
130+
* @expectedException LogicException
131131
* @expectedExceptionMessage You must call the parent constructor in "Foo5Command::__construct()"
132132
*/
133133
public function testAddCommandWithEmptyContructor()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.