Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 84fec70

Browse filesBrowse files
minor #33447 [DI] fix failure (nicolas-grekas)
This PR was merged into the 4.3 branch. Discussion ---------- [DI] fix failure | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 3b40cb1 [DI] fix failure
2 parents c0f4037 + 3b40cb1 commit 84fec70
Copy full SHA for 84fec70

File tree

1 file changed

+5
-2
lines changed
Filter options

1 file changed

+5
-2
lines changed

‎src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php
+5-2Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,8 +306,11 @@ public function testTaggedArgumentsWithIndex()
306306
$taggedIterator = new TaggedIteratorArgument('foo', 'barfoo', 'foobar', true);
307307
$this->assertEquals(new ServiceLocatorArgument($taggedIterator), $container->getDefinition('foo_service_tagged_locator')->getArgument(0));
308308

309-
$taggedIterator = new TaggedIteratorArgument('foo', null, null, true);
310-
$this->assertEquals(new ServiceLocatorArgument($taggedIterator), $container->getDefinition('bar_service_tagged_locator')->getArgument(0));
309+
if (is_subclass_of('Symfony\Component\Yaml\Exception\ExceptionInterface', 'Throwable')) {
310+
// this test is not compatible with Yaml v3
311+
$taggedIterator = new TaggedIteratorArgument('foo', null, null, true);
312+
$this->assertEquals(new ServiceLocatorArgument($taggedIterator), $container->getDefinition('bar_service_tagged_locator')->getArgument(0));
313+
}
311314
}
312315

313316
public function testNameOnlyTagsAreAllowedAsString()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.