Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 83c3282

Browse filesBrowse files
fabpotfabpot
committed
minor #24739 [FrameworkBundle][Routing] Remove unused logger argument (ogizanagi)
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle][Routing] Remove unused logger argument | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This argument was never used as far as the FrameworkBundle Router was. But actually don't we want to add the `$logger` argument to this class? It's used by the `UrlGenerator` when `router.strict_requirements` is `false` for instance: <img width="1064" alt="screenshot 2017-10-29 a 09 57 31" src="https://user-images.githubusercontent.com/2211145/32142080-482bc64e-bc90-11e7-8382-b78b507bae48.PNG"> Commits ------- dc9492e [FrameworkBundle][Routing] Remove unused logger argument
2 parents 51cfaf8 + dc9492e commit 83c3282
Copy full SHA for 83c3282

File tree

1 file changed

+0
-2
lines changed
Filter options
  • src/Symfony/Bundle/FrameworkBundle/Resources/config

1 file changed

+0
-2
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
</service>
5454

5555
<service id="router.default" class="%router.class%" public="false">
56-
<tag name="monolog.logger" channel="router" />
5756
<argument type="service" id="service_container" />
5857
<argument>%router.resource%</argument>
5958
<argument type="collection">
@@ -69,7 +68,6 @@
6968
<argument key="matcher_cache_class">%router.options.matcher.cache_class%</argument>
7069
</argument>
7170
<argument type="service" id="router.request_context" on-invalid="ignore" />
72-
<argument type="service" id="logger" on-invalid="ignore" />
7371
</service>
7472

7573
<service id="router" alias="router.default" />

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.