Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 838ecb6

Browse filesBrowse files
[Runtime][ErrorHandler] Don't mess with ini_set('assert.warning')
1 parent 6f2e603 commit 838ecb6
Copy full SHA for 838ecb6

File tree

Expand file treeCollapse file tree

3 files changed

+3
-7
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+3
-7
lines changed

‎src/Symfony/Component/ErrorHandler/Debug.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/ErrorHandler/Debug.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public static function enable(): ErrorHandler
3131

3232
@ini_set('zend.assertions', 1);
3333
ini_set('assert.active', 1);
34-
ini_set('assert.warning', 0);
3534
ini_set('assert.exception', 1);
3635

3736
DebugClassLoader::enable();

‎src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/ErrorHandler/Tests/ErrorHandlerTest.php
+3-5Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -669,9 +669,8 @@ public function testAssertQuietEval()
669669
ini_set('zend.assertions', 1),
670670
ini_set('assert.active', 1),
671671
ini_set('assert.bail', 0),
672-
ini_set('assert.warning', 1),
673672
ini_set('assert.callback', null),
674-
ini_set('assert.exception', 0),
673+
\ini_get('assert.exception'),
675674
];
676675

677676
$logger = new BufferingLogger();
@@ -687,9 +686,8 @@ public function testAssertQuietEval()
687686
ini_set('zend.assertions', $ini[0]);
688687
ini_set('assert.active', $ini[1]);
689688
ini_set('assert.bail', $ini[2]);
690-
ini_set('assert.warning', $ini[3]);
691-
ini_set('assert.callback', $ini[4]);
692-
ini_set('assert.exception', $ini[5]);
689+
ini_set('assert.callback', $ini[3]);
690+
ini_set('assert.exception', $ini[4]);
693691
}
694692

695693
$logs = $logger->cleanLogs();

‎src/Symfony/Component/Runtime/Internal/BasicErrorHandler.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Runtime/Internal/BasicErrorHandler.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public static function register(bool $debug): void
3232
if (0 <= \ini_get('zend.assertions')) {
3333
ini_set('zend.assertions', 1);
3434
ini_set('assert.active', $debug);
35-
ini_set('assert.warning', 0);
3635
ini_set('assert.exception', 1);
3736
}
3837

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.