Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7f52292

Browse filesBrowse files
committed
feature #23376 [Process] Remove enhanced Windows compatibility (maidmaid)
This PR was merged into the 4.0-dev branch. Discussion ---------- [Process] Remove enhanced Windows compatibility | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / In 4.0, enhanced Windows compatibility is always enabled. Commits ------- 6033503 Remove enhancement Windows compatibility
2 parents 06e21f7 + 6033503 commit 7f52292
Copy full SHA for 7f52292

File tree

Expand file treeCollapse file tree

1 file changed

+1
-36
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-36
lines changed

‎src/Symfony/Component/Process/Process.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Process/Process.php
+1-36Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ class Process implements \IteratorAggregate
6464
private $outputDisabled = false;
6565
private $stdout;
6666
private $stderr;
67-
private $enhanceWindowsCompatibility = true;
6867
private $enhanceSigchildCompatibility;
6968
private $process;
7069
private $status = self::STATUS_READY;
@@ -295,7 +294,7 @@ public function start(callable $callback = null, array $env = array())
295294

296295
$options = array('suppress_errors' => true);
297296

298-
if ('\\' === DIRECTORY_SEPARATOR && $this->enhanceWindowsCompatibility) {
297+
if ('\\' === DIRECTORY_SEPARATOR) {
299298
$options['bypass_shell'] = true;
300299
$commandline = $this->prepareWindowsCommandLine($commandline, $envBackup, $env);
301300
} elseif (!$this->useFileHandles && $this->enhanceSigchildCompatibility && $this->isSigchildEnabled()) {
@@ -1154,40 +1153,6 @@ public function setInput($input)
11541153
return $this;
11551154
}
11561155

1157-
/**
1158-
* Gets whether or not Windows compatibility is enabled.
1159-
*
1160-
* This is true by default.
1161-
*
1162-
* @return bool
1163-
*
1164-
* @deprecated since version 3.3, to be removed in 4.0. Enhanced Windows compatibility will always be enabled.
1165-
*/
1166-
public function getEnhanceWindowsCompatibility()
1167-
{
1168-
@trigger_error(sprintf('The %s() method is deprecated since version 3.3 and will be removed in 4.0. Enhanced Windows compatibility will always be enabled.', __METHOD__), E_USER_DEPRECATED);
1169-
1170-
return $this->enhanceWindowsCompatibility;
1171-
}
1172-
1173-
/**
1174-
* Sets whether or not Windows compatibility is enabled.
1175-
*
1176-
* @param bool $enhance
1177-
*
1178-
* @return self The current Process instance
1179-
*
1180-
* @deprecated since version 3.3, to be removed in 4.0. Enhanced Windows compatibility will always be enabled.
1181-
*/
1182-
public function setEnhanceWindowsCompatibility($enhance)
1183-
{
1184-
@trigger_error(sprintf('The %s() method is deprecated since version 3.3 and will be removed in 4.0. Enhanced Windows compatibility will always be enabled.', __METHOD__), E_USER_DEPRECATED);
1185-
1186-
$this->enhanceWindowsCompatibility = (bool) $enhance;
1187-
1188-
return $this;
1189-
}
1190-
11911156
/**
11921157
* Returns whether sigchild compatibility mode is activated or not.
11931158
*

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.