Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7e96b12

Browse filesBrowse files
committed
minor #44175 [Ldap] Add missing security-http dependency (derrabus)
This PR was merged into the 5.3 branch. Discussion ---------- [Ldap] Add missing security-http dependency | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A On the low/high deps runs, certain tests of the LDAP component are skipped because we don't install the security-http component. This PR attempts to change that. Commits ------- ecc1b6b [Ldap] Add missing security-http dependency
2 parents 2e950c6 + ecc1b6b commit 7e96b12
Copy full SHA for 7e96b12

File tree

Expand file treeCollapse file tree

2 files changed

+4
-14
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-14
lines changed

‎src/Symfony/Component/Ldap/Tests/Security/CheckLdapCredentialsListenerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Ldap/Tests/Security/CheckLdapCredentialsListenerTest.php
-12Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ class CheckLdapCredentialsListenerTest extends TestCase
4141

4242
protected function setUp(): void
4343
{
44-
if (!interface_exists(AuthenticatorInterface::class)) {
45-
$this->markTestSkipped('This test requires symfony/security-http:^5.1');
46-
}
47-
4844
$this->ldap = $this->createMock(LdapInterface::class);
4945
}
5046

@@ -61,10 +57,6 @@ public function testShouldNotCheckPassport($authenticator, $passport)
6157

6258
public function provideShouldNotCheckPassport()
6359
{
64-
if (!interface_exists(AuthenticatorInterface::class)) {
65-
$this->markTestSkipped('This test requires symfony/security-http:^5.1');
66-
}
67-
6860
// no LdapBadge
6961
yield [new TestAuthenticator(), new Passport(new UserBadge('test'), new PasswordCredentials('s3cret'))];
7062

@@ -110,10 +102,6 @@ public function testWrongPassport($passport)
110102

111103
public function provideWrongPassportData()
112104
{
113-
if (!interface_exists(AuthenticatorInterface::class)) {
114-
$this->markTestSkipped('This test requires symfony/security-http:^5.1');
115-
}
116-
117105
// no password credentials
118106
yield [new SelfValidatingPassport(new UserBadge('test'), [new LdapBadge('app.ldap')])];
119107

‎src/Symfony/Component/Ldap/composer.json

Copy file name to clipboardExpand all lines: src/Symfony/Component/Ldap/composer.json
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,13 @@
2222
"ext-ldap": "*"
2323
},
2424
"require-dev": {
25-
"symfony/security-core": "^5.3"
25+
"symfony/security-core": "^5.3",
26+
"symfony/security-http": "^5.2"
2627
},
2728
"conflict": {
2829
"symfony/options-resolver": "<4.4",
29-
"symfony/security-core": "<5.3"
30+
"symfony/security-core": "<5.3",
31+
"symfony/security-http": "<5.2"
3032
},
3133
"autoload": {
3234
"psr-4": { "Symfony\\Component\\Ldap\\": "" },

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.