Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 795a240

Browse filesBrowse files
fabpotfabpot
committed
minor #20884 [Finder] Deprecate ExceptionInterface (ogizanagi)
This PR was merged into the 3.3-dev branch. Discussion ---------- [Finder] Deprecate ExceptionInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A This interface was missed in #15805, and should have been removed in 3.0. Ideally, the component should have such an interface, though, as other components does. But the only domain exception in this component is an `AccessDeniedException` used by the `RecursiveDirectoryIterator`. So it isn't worth it right now. I think this interface was almost internal actually, but anyway the `\Symfony\Component\Finder\Adapter\AdapterInterface` interface does not exist anymore. So the `ExceptionInterface::getAdapter()` signature cannot be satisfied anyway. I guess anyone relying on this interface in any way should have notice that and removed anything related to Symfony Finder's adapters when upgrading to 3.0. Should we consider removing it directly in the 3.1 branch instead? Commits ------- 1b600b0 [Finder] Deprecate ExceptionInterface
2 parents 51d13cc + 1b600b0 commit 795a240
Copy full SHA for 795a240

File tree

Expand file treeCollapse file tree

3 files changed

+12
-0
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+12
-0
lines changed

‎UPGRADE-3.3.md

Copy file name to clipboardExpand all lines: UPGRADE-3.3.md
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ ClassLoader
77
* The ApcClassLoader, WinCacheClassLoader and XcacheClassLoader classes have been deprecated
88
in favor of the `--apcu-autoloader` option introduced in composer 1.3
99

10+
Finder
11+
------
12+
13+
* The `ExceptionInterface` has been deprecated and will be removed in 4.0.
14+
1015
Security
1116
--------
1217

‎UPGRADE-4.0.md

Copy file name to clipboardExpand all lines: UPGRADE-4.0.md
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ ExpressionLanguage
4343
class has been removed. You should use the `CacheItemPoolInterface` interface
4444
instead.
4545

46+
Finder
47+
------
48+
49+
* The `ExceptionInterface` has been removed.
50+
4651
Form
4752
----
4853

‎src/Symfony/Component/Finder/Exception/ExceptionInterface.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Finder/Exception/ExceptionInterface.php
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313

1414
/**
1515
* @author Jean-François Simon <contact@jfsimon.fr>
16+
*
17+
* @deprecated since 3.3, to be removed in 4.0.
1618
*/
1719
interface ExceptionInterface
1820
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.