Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 76dd7b0

Browse filesBrowse files
fabpotfabpot
committed
bug #22523 [WebProfilerBundle] Fixed the flickering when loading complex profiler panels (javiereguiluz)
This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] Fixed the flickering when loading complex profiler panels | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When profiler panels are complex (usually, when they contain a lot of VarDumper calls) they take some time to load and this results in a ugly flickering of the sidebar. This PR fixes this problem adding some minor CSS changes and reordering some HTML elements in the layout. These changes shouldn't affect the design in any way but please, test it in your own browsers. Thanks! | Before | After | --- | --- | ![profiler-before](https://cloud.githubusercontent.com/assets/73419/25390425/c7ebb16e-29d3-11e7-9d3f-722d5b24b95a.gif) | ![profiler-after](https://cloud.githubusercontent.com/assets/73419/25390426/c80994ea-29d3-11e7-910c-7a2564b17ffa.gif) Commits ------- e9132b3 Fixed the flickering when loading complex profiler panels
2 parents 9af7354 + e9132b3 commit 76dd7b0
Copy full SHA for 76dd7b0

File tree

3 files changed

+9
-9
lines changed
Filter options

3 files changed

+9
-9
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/layout.html.twig

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/layout.html.twig
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,6 @@
4343

4444
<div id="content" class="container">
4545
<div id="main">
46-
<div id="collector-wrapper">
47-
<div id="collector-content">
48-
{{ include('@WebProfiler/Profiler/base_js.html.twig') }}
49-
{% block panel '' %}
50-
</div>
51-
</div>
52-
5346
<div id="sidebar">
5447
<div id="sidebar-shortcuts">
5548
<div class="shortcuts">
@@ -87,6 +80,13 @@
8780
</ul>
8881
{% endif %}
8982
</div>
83+
84+
<div id="collector-wrapper">
85+
<div id="collector-content">
86+
{{ include('@WebProfiler/Profiler/base_js.html.twig') }}
87+
{% block panel '' %}
88+
</div>
89+
</div>
9090
</div>
9191
</div>
9292
{% endblock %}

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ tr.status-warning td {
433433
}
434434
#main {
435435
display: flex;
436-
flex-direction: row-reverse;
436+
flex-direction: row;
437437
min-height: 100%;
438438
}
439439
#sidebar {

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/search.html.twig

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/search.html.twig
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div id="sidebar-search">
1+
<div id="sidebar-search" class="hidden">
22
<form action="{{ path('_profiler_search') }}" method="get">
33
<div class="form-group">
44
<label for="ip">IP</label>

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.