Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 73b0ca0

Browse filesBrowse files
committed
bug #31301 [Intl] Fix LocaleDataGenerator (ro0NL)
This PR was merged into the 4.3-dev branch. Discussion ---------- [Intl] Fix LocaleDataGenerator | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Forgotten in #28846 The `getName()` method for scripts/regions/languages is stilled needed during locale generation. Commits ------- 137ce3f [Intl] Fix LocaleDataGenerator
2 parents ac4b322 + 137ce3f commit 73b0ca0
Copy full SHA for 73b0ca0

File tree

3 files changed

+27
-3
lines changed
Filter options

3 files changed

+27
-3
lines changed

‎src/Symfony/Component/Intl/Data/Provider/LanguageDataProvider.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Intl/Data/Provider/LanguageDataProvider.php
+13-1Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
*
2020
* @author Bernhard Schussek <bschussek@gmail.com>
2121
*
22-
* @internal to be removed in 5.0.
22+
* @internal
2323
*/
2424
class LanguageDataProvider
2525
{
@@ -38,11 +38,17 @@ public function __construct(string $path, BundleEntryReaderInterface $reader)
3838
$this->reader = $reader;
3939
}
4040

41+
/**
42+
* @internal to be removed in 5.0.
43+
*/
4144
public function getLanguages()
4245
{
4346
return $this->reader->readEntry($this->path, 'meta', ['Languages']);
4447
}
4548

49+
/**
50+
* @internal to be removed in 5.0.
51+
*/
4652
public function getAliases()
4753
{
4854
return $this->reader->readEntry($this->path, 'root', ['Aliases']);
@@ -57,6 +63,9 @@ public function getName($language, $displayLocale = null)
5763
return $this->reader->readEntry($this->path, $displayLocale, ['Names', $language]);
5864
}
5965

66+
/**
67+
* @internal to be removed in 5.0.
68+
*/
6069
public function getNames($displayLocale = null)
6170
{
6271
if (null === $displayLocale) {
@@ -75,6 +84,9 @@ public function getNames($displayLocale = null)
7584
return $languages;
7685
}
7786

87+
/**
88+
* @internal to be removed in 5.0.
89+
*/
7890
public function getAlpha3Code($language)
7991
{
8092
return $this->reader->readEntry($this->path, 'meta', ['Alpha2ToAlpha3', $language]);

‎src/Symfony/Component/Intl/Data/Provider/RegionDataProvider.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Intl/Data/Provider/RegionDataProvider.php
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
*
2020
* @author Bernhard Schussek <bschussek@gmail.com>
2121
*
22-
* @internal to be removed in 5.0.
22+
* @internal
2323
*/
2424
class RegionDataProvider
2525
{
@@ -38,6 +38,9 @@ public function __construct(string $path, BundleEntryReaderInterface $reader)
3838
$this->reader = $reader;
3939
}
4040

41+
/**
42+
* @internal to be removed in 5.0.
43+
*/
4144
public function getRegions()
4245
{
4346
return $this->reader->readEntry($this->path, 'meta', ['Regions']);
@@ -52,6 +55,9 @@ public function getName($region, $displayLocale = null)
5255
return $this->reader->readEntry($this->path, $displayLocale, ['Names', $region]);
5356
}
5457

58+
/**
59+
* @internal to be removed in 5.0.
60+
*/
5561
public function getNames($displayLocale = null)
5662
{
5763
if (null === $displayLocale) {

‎src/Symfony/Component/Intl/Data/Provider/ScriptDataProvider.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Intl/Data/Provider/ScriptDataProvider.php
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
*
2020
* @author Bernhard Schussek <bschussek@gmail.com>
2121
*
22-
* @internal to be removed in 5.0.
22+
* @internal
2323
*/
2424
class ScriptDataProvider
2525
{
@@ -38,6 +38,9 @@ public function __construct(string $path, BundleEntryReaderInterface $reader)
3838
$this->reader = $reader;
3939
}
4040

41+
/**
42+
* @internal to be removed in 5.0.
43+
*/
4144
public function getScripts()
4245
{
4346
return $this->reader->readEntry($this->path, 'meta', ['Scripts']);
@@ -52,6 +55,9 @@ public function getName($script, $displayLocale = null)
5255
return $this->reader->readEntry($this->path, $displayLocale, ['Names', $script]);
5356
}
5457

58+
/**
59+
* @internal to be removed in 5.0.
60+
*/
5561
public function getNames($displayLocale = null)
5662
{
5763
if (null === $displayLocale) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.