Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7369bc9

Browse filesBrowse files
bug #47491 [HttpKernel] Prevent exception in RequestDataCollector if request stack is empty (aschempp)
This PR was merged into the 5.4 branch. Discussion ---------- [HttpKernel] Prevent exception in RequestDataCollector if request stack is empty | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix contao/contao#5251 | License | MIT | Doc PR | - Commits ------- 89e1398 Prevent exception if request stack is empty
2 parents 8497822 + 89e1398 commit 7369bc9
Copy full SHA for 7369bc9

File tree

2 files changed

+10
-1
lines changed
Filter options

2 files changed

+10
-1
lines changed

‎src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function collect(Request $request, Response $response, \Throwable $except
110110
'session_metadata' => $sessionMetadata,
111111
'session_attributes' => $sessionAttributes,
112112
'session_usages' => array_values($this->sessionUsages),
113-
'stateless_check' => $this->requestStack && $this->requestStack->getMainRequest()->attributes->get('_stateless', false),
113+
'stateless_check' => $this->requestStack && ($mainRequest = $this->requestStack->getMainRequest()) && $mainRequest->attributes->get('_stateless', false),
114114
'flashes' => $flashes,
115115
'path_info' => $request->getPathInfo(),
116116
'controller' => 'n/a',

‎src/Symfony/Component/HttpKernel/Tests/DataCollector/RequestDataCollectorTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/DataCollector/RequestDataCollectorTest.php
+9Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,15 @@ public function testStatelessCheck()
312312
$collector->lateCollect();
313313

314314
$this->assertTrue($collector->getStatelessCheck());
315+
316+
$requestStack = new RequestStack();
317+
$request = $this->createRequest();
318+
319+
$collector = new RequestDataCollector($requestStack);
320+
$collector->collect($request, $response = $this->createResponse());
321+
$collector->lateCollect();
322+
323+
$this->assertFalse($collector->getStatelessCheck());
315324
}
316325

317326
public function testItHidesPassword()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.