Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 71a8ecb

Browse filesBrowse files
committed
minor #33289 [DomCrawler] Fix FileFormField PHPDoc (dunglas)
This PR was squashed before being merged into the 3.4 branch (closes #33289). Discussion ---------- [DomCrawler] Fix FileFormField PHPDoc | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a `null` is a valid value, it is used in case of errors. Then the parent class must allow `null` values too. I think it's important regarding the ongoing process of adding typehints everywhere. Commits ------- 162bfc3 [DomCrawler] Fix FileFormField PHPDoc
2 parents 87c8d2d + 162bfc3 commit 71a8ecb
Copy full SHA for 71a8ecb

File tree

Expand file treeCollapse file tree

3 files changed

+3
-3
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+3
-3
lines changed

‎src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public function untick()
113113
/**
114114
* Sets the value of the field.
115115
*
116-
* @param string|array $value The value of the field
116+
* @param string|array|bool $value The value of the field
117117
*
118118
* @throws \InvalidArgumentException When value type provided is not correct
119119
*/

‎src/Symfony/Component/DomCrawler/Field/FileFormField.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DomCrawler/Field/FileFormField.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function upload($value)
4848
/**
4949
* Sets the value of the field.
5050
*
51-
* @param string $value The value of the field
51+
* @param string|null $value The value of the field
5252
*/
5353
public function setValue($value)
5454
{

‎src/Symfony/Component/DomCrawler/Field/FormField.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DomCrawler/Field/FormField.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public function getValue()
9999
/**
100100
* Sets the value of the field.
101101
*
102-
* @param string $value The value of the field
102+
* @param string|array|bool|null $value The value of the field
103103
*/
104104
public function setValue($value)
105105
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.