Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 70e1bc0

Browse filesBrowse files
committed
[HttpKernel] Remove time-sensitivity from InlineFragmentRendererTest
1 parent cefe78d commit 70e1bc0
Copy full SHA for 70e1bc0

File tree

1 file changed

+14
-2
lines changed
Filter options

1 file changed

+14
-2
lines changed

‎src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php
+14-2Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
namespace Symfony\Component\HttpKernel\Tests\Fragment;
1313

14+
use PHPUnit\Framework\Constraint\IsEqual;
1415
use PHPUnit\Framework\TestCase;
1516
use Symfony\Component\EventDispatcher\EventDispatcher;
1617
use Symfony\Component\HttpFoundation\Request;
@@ -261,13 +262,24 @@ public function testIpAddressOfRangedTrustedProxyIsSetAsRemote()
261262
/**
262263
* Creates a Kernel expecting a request equals to $request.
263264
*/
264-
private function getKernelExpectingRequest(Request $request, $strict = false)
265+
private function getKernelExpectingRequest(Request $expectedRequest)
265266
{
266267
$kernel = $this->createMock(HttpKernelInterface::class);
267268
$kernel
268269
->expects($this->once())
269270
->method('handle')
270-
->with($request)
271+
->with($this->callback(function (Request $request) use ($expectedRequest) {
272+
$requestClone = clone $request;
273+
$expectedRequestClone = clone $expectedRequest;
274+
275+
$irrelevantServerKeys = ['REQUEST_TIME', 'REQUEST_TIME_FLOAT'];
276+
foreach ($irrelevantServerKeys as $irrelevantServerKey) {
277+
$requestClone->server->remove($irrelevantServerKey);
278+
$expectedRequestClone->server->remove($irrelevantServerKey);
279+
}
280+
281+
return (new IsEqual($expectedRequestClone))->evaluate($requestClone);
282+
}))
271283
->willReturn(new Response('foo'));
272284

273285
return $kernel;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.