Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6ffe782

Browse filesBrowse files
committed
remove support for deprecated "threadKey" parameter
1 parent 020d7c9 commit 6ffe782
Copy full SHA for 6ffe782

File tree

2 files changed

+0
-10
lines changed
Filter options

2 files changed

+0
-10
lines changed

‎src/Symfony/Component/Notifier/Bridge/GoogleChat/GoogleChatTransportFactory.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Notifier/Bridge/GoogleChat/GoogleChatTransportFactory.php
-9Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,7 @@ public function create(Dsn $dsn): TransportInterface
3838
$space = explode('/', $dsn->getPath())[1];
3939
$accessKey = $this->getUser($dsn);
4040
$accessToken = $this->getPassword($dsn);
41-
4241
$threadKey = $dsn->getOption('thread_key');
43-
44-
/*
45-
* Remove this check for 5.4
46-
*/
47-
if (null === $threadKey && null !== $dsn->getOption('threadKey')) {
48-
throw new IncompleteDsnException('GoogleChat DSN has changed since 5.3, use "thread_key" instead of "threadKey" parameter.');
49-
}
50-
5142
$host = 'default' === $dsn->getHost() ? null : $dsn->getHost();
5243
$port = $dsn->getPort();
5344

‎src/Symfony/Component/Notifier/Bridge/GoogleChat/Tests/GoogleChatTransportFactoryTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Notifier/Bridge/GoogleChat/Tests/GoogleChatTransportFactoryTest.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public function supportsProvider(): iterable
4747
public function incompleteDsnProvider(): iterable
4848
{
4949
yield 'missing credentials' => ['googlechat://chat.googleapis.com/v1/spaces/AAAAA_YYYYY/messages'];
50-
yield 'using old option: threadKey' => ['googlechat://abcde-fghij:kl_mnopqrstwxyz%3D@chat.googleapis.com/AAAAA_YYYYY?threadKey=abcdefg', 'GoogleChat DSN has changed since 5.3, use "thread_key" instead of "threadKey" parameter.']; // can be removed in Symfony 5.4
5150
}
5251

5352
public function unsupportedSchemeProvider(): iterable

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.