Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 6f9f4be

Browse filesBrowse files
derrabusderrabus
committed
minor #41790 Pin masterminds/html5 to the master branch for PHP 8.1 (derrabus)
This PR was merged into the 4.4 branch. Discussion ---------- Pin masterminds/html5 to the master branch for PHP 8.1 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Our tests on PHP 8.1 require the changes I've made in Masterminds/html5-php#207. Unfortunately, Composer will not pick a version with those changes because of the reasons described in Masterminds/html5-php#209. This PR adds a small workaround to the PHP 8.1 job which I'll happily revert as soon as Masterminds/html5-php#209 is resolved. Commits ------- 9c69e77 Pin masterminds/html5 to the master branch for PHP 8.1
2 parents 124ecf0 + 9c69e77 commit 6f9f4be
Copy full SHA for 6f9f4be

File tree

1 file changed

+2
-0
lines changed
Filter options

1 file changed

+2
-0
lines changed

‎.github/workflows/tests.yml

Copy file name to clipboardExpand all lines: .github/workflows/tests.yml
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ jobs:
141141
run: |
142142
echo "::group::fake PHP version"
143143
composer config platform.php 8.0.99
144+
echo "::group::Adjust dependencies"
145+
composer require --dev --no-update masterminds/html5:~2.7.5@dev
144146
echo "::group::composer update"
145147
composer update --no-progress --ansi
146148
echo "::endgroup::"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.