Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 6e3fa5a

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
minor #41918 CS fixes (nicolas-grekas)
This PR was merged into the 4.4 branch. Discussion ---------- CS fixes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - With a rule hinted by `@julienfalque` in PHP-CS-Fixer/PHP-CS-Fixer#5785 Commits ------- 31e1a97 CS fixes
2 parents ffb4795 + 31e1a97 commit 6e3fa5a
Copy full SHA for 6e3fa5a

File tree

Expand file treeCollapse file tree

9 files changed

+10
-13
lines changed
Filter options
Expand file treeCollapse file tree

9 files changed

+10
-13
lines changed

‎.php-cs-fixer.dist.php

Copy file name to clipboardExpand all lines: .php-cs-fixer.dist.php
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
'@Symfony' => true,
1212
'@Symfony:risky' => true,
1313
'protected_to_private' => false,
14+
'nullable_type_declaration_for_default_null_value' => ['use_nullable_type_declaration' => false],
1415
])
1516
->setRiskyAllowed(true)
1617
->setFinder(

‎src/Symfony/Bridge/Doctrine/Tests/ManagerRegistryTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Doctrine/Tests/ManagerRegistryTest.php
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ class ManagerRegistryTest extends TestCase
1919
{
2020
public static function setUpBeforeClass(): void
2121
{
22-
if (!class_exists(\PHPUnit_Framework_TestCase::class)) {
23-
self::markTestSkipped('proxy-manager-bridge is not yet compatible with namespaced phpunit versions.');
24-
}
2522
$test = new PhpDumperTest();
2623
$test->testDumpContainerWithProxyServiceWillShareProxies();
2724
}

‎src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/CachePools/bundles.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/CachePools/bundles.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
*/
1111

1212
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
13-
use Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\TestBundle;
1413

1514
return [
1615
new FrameworkBundle(),

‎src/Symfony/Component/Cache/Tests/Adapter/ArrayAdapterTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Cache/Tests/Adapter/ArrayAdapterTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function testGetValuesHitAndMiss()
4949

5050
// Fail (should be missing from $values)
5151
$item = $cache->getItem('buz');
52-
$cache->save($item->set(function() {}));
52+
$cache->save($item->set(function () {}));
5353

5454
$values = $cache->getValues();
5555

‎src/Symfony/Component/Config/Tests/Definition/Builder/ExprBuilderTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Tests/Definition/Builder/ExprBuilderTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ protected function getTestBuilder(): ExprBuilder
225225
*
226226
* @return array The finalized config values
227227
*/
228-
protected function finalizeTestBuilder(NodeDefinition $nodeDefinition, ?array $config = null): array
228+
protected function finalizeTestBuilder(NodeDefinition $nodeDefinition, array $config = null): array
229229
{
230230
return $nodeDefinition
231231
->end()

‎src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public function testIsFreshForDeletedResources()
6464
/**
6565
* @dataProvider provideHashedSignature
6666
*/
67-
public function testHashedSignature(bool $changeExpected, int $changedLine, ?string $changedCode, ?\Closure $setContext = null)
67+
public function testHashedSignature(bool $changeExpected, int $changedLine, ?string $changedCode, \Closure $setContext = null)
6868
{
6969
if ($setContext) {
7070
$setContext();

‎src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ protected function setUp(): void
4040

4141
$r = new \ReflectionClass(\Memcached::class);
4242
$methodsToMock = array_map(function ($m) { return $m->name; }, $r->getMethods(\ReflectionMethod::IS_PUBLIC));
43-
$methodsToMock = array_diff($methodsToMock, ['getDelayed','getDelayedByKey']);
43+
$methodsToMock = array_diff($methodsToMock, ['getDelayed', 'getDelayedByKey']);
4444

4545
$this->memcached = $this->getMockBuilder(\Memcached::class)
4646
->disableOriginalConstructor()

‎src/Symfony/Component/Mailer/Transport/Dsn.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Mailer/Transport/Dsn.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ final class Dsn
2525
private $port;
2626
private $options;
2727

28-
public function __construct(string $scheme, string $host, ?string $user = null, ?string $password = null, ?int $port = null, array $options = [])
28+
public function __construct(string $scheme, string $host, string $user = null, string $password = null, int $port = null, array $options = [])
2929
{
3030
$this->scheme = $scheme;
3131
$this->host = $host;

‎src/Symfony/Component/Yaml/Exception/ParseException.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Yaml/Exception/ParseException.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ class ParseException extends RuntimeException
2424
private $rawMessage;
2525

2626
/**
27-
* @param string $message The error message
28-
* @param int $parsedLine The line where the error occurred
29-
* @param string|null $snippet The snippet of code near the problem
30-
* @param string|null $parsedFile The file name where the error occurred
27+
* @param string $message The error message
28+
* @param int $parsedLine The line where the error occurred
29+
* @param string|null $snippet The snippet of code near the problem
30+
* @param string|null $parsedFile The file name where the error occurred
3131
*/
3232
public function __construct(string $message, int $parsedLine = -1, string $snippet = null, string $parsedFile = null, \Throwable $previous = null)
3333
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.