Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6b8ff62

Browse filesBrowse files
committed
minor #30778 [Intl] Simplify the compile binary (jakzal)
This PR was merged into the 3.4 branch. Discussion ---------- [Intl] Simplify the compile binary | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | - The intl docker image comes with build-essential packages now, so there's no need for additional installation steps. re #30584 Commits ------- b3184c2 [Intl] Simplify the compile binary
2 parents 755d481 + b3184c2 commit 6b8ff62
Copy full SHA for 6b8ff62

File tree

1 file changed

+10
-8
lines changed
Filter options
  • src/Symfony/Component/Intl/Resources/bin

1 file changed

+10
-8
lines changed
+10-8Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
#!/usr/bin/env bash
22

3-
if [[ $1 == force || ! $(docker ps -a | grep symfony-intl) ]]; then
4-
docker rm -f symfony-intl
5-
docker create --name symfony-intl -it -v /tmp:/tmp -v $(pwd):/app -w /app jakzal/php-intl:7.2-63.1 bash
6-
docker start symfony-intl
7-
docker exec symfony-intl bash -xc "apt-get update && apt-get -y install build-essential"
8-
else
9-
docker start symfony-intl
3+
if [[ $1 == force ]]; then
4+
docker pull jakzal/php-intl
105
fi;
116

12-
docker exec -u $(id -u):$(id -g) symfony-intl php src/Symfony/Component/Intl/Resources/bin/update-data.php
7+
docker run \
8+
-it --rm --name symfony-intl \
9+
-u $(id -u):$(id -g) \
10+
-v /tmp/symfony/icu:/tmp \
11+
-v $(pwd):/symfony \
12+
-w /symfony \
13+
jakzal/php-intl:latest \
14+
php src/Symfony/Component/Intl/Resources/bin/update-data.php

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.