Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 671befa

Browse filesBrowse files
committed
[HttpFoundation][FrameworkBundle] Fix default locale is ignored when set_locale_from_accept_language is used
1 parent d6a965a commit 671befa
Copy full SHA for 671befa

File tree

2 files changed

+23
-1
lines changed
Filter options

2 files changed

+23
-1
lines changed

‎src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private function setLocale(Request $request): void
6969
if ($locale = $request->attributes->get('_locale')) {
7070
$request->setLocale($locale);
7171
} elseif ($this->useAcceptLanguageHeader) {
72-
if ($preferredLanguage = $request->getPreferredLanguage($this->enabledLocales)) {
72+
if ($request->getLanguages() && $preferredLanguage = $request->getPreferredLanguage($this->enabledLocales)) {
7373
$request->setLocale($preferredLanguage);
7474
}
7575
$request->attributes->set('_vary_by_language', true);

‎src/Symfony/Component/HttpKernel/Tests/EventListener/LocaleListenerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/EventListener/LocaleListenerTest.php
+22Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,28 @@ public function testRequestPreferredLocaleFromAcceptLanguageHeader()
131131
$this->assertEquals('fr', $request->getLocale());
132132
}
133133

134+
public function testRequestDefaultLocaleIfNoAcceptLanguageHeaderIsPresent()
135+
{
136+
$request = new Request();
137+
$listener = new LocaleListener($this->requestStack, 'de', null, true, ['lt', 'de']);
138+
$event = $this->getEvent($request);
139+
140+
$listener->setDefaultLocale($event);
141+
$listener->onKernelRequest($event);
142+
$this->assertEquals('de', $request->getLocale());
143+
}
144+
145+
public function testRequestVaryByLanguageAttributeIsSetIfUsingAcceptLanguageHeader()
146+
{
147+
$request = new Request();
148+
$listener = new LocaleListener($this->requestStack, 'de', null, true, ['lt', 'de']);
149+
$event = $this->getEvent($request);
150+
151+
$listener->setDefaultLocale($event);
152+
$listener->onKernelRequest($event);
153+
$this->assertTrue($request->attributes->get('_vary_by_language'));
154+
}
155+
134156
public function testRequestSecondPreferredLocaleFromAcceptLanguageHeader()
135157
{
136158
$request = Request::create('/');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.