Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 653e42d

Browse filesBrowse files
bug #59908 [Messenger] Reduce keepalive request noise (ro0NL)
This PR was merged into the 7.2 branch. Discussion ---------- [Messenger] Reduce keepalive request noise | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Currently `messenger:consume --keepalive` creates a lot of noise (INFO log every 5 sec by default). ``` 13:34:59 INFO [messenger] Sending keepalive request. 13:35:04 INFO [messenger] Sending keepalive request. ``` I propose to use DEBUG instead. We can also remove this log, since there's already a keepalive log per message ID: https://github.com/symfony/symfony/blob/8b008510a48adba218d6358a3ab52141daacbaa8/src/Symfony/Component/Messenger/Worker.php#L303-L306 cc `@HypeMC` Commits ------- 01bfc8d [Messenger] Reduce keepalive request noise
2 parents cc8ea7f + 01bfc8d commit 653e42d
Copy full SHA for 653e42d

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Command/ConsumeMessagesCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ public function handleSignal(int $signal, int|false $previousExitCode = 0): int|
290290
}
291291

292292
if (\SIGALRM === $signal) {
293-
$this->logger?->info('Sending keepalive request.', ['transport_names' => $this->worker->getMetadata()->getTransportNames()]);
293+
$this->logger?->debug('Sending keepalive request.', ['transport_names' => $this->worker->getMetadata()->getTransportNames()]);
294294

295295
$this->worker->keepalive($this->getApplication()->getAlarmInterval());
296296

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.