Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 6118f5e

Browse filesBrowse files
xabbuhxabbuh
committed
trigger some deprecations for legacy methods
1 parent 82b36e4 commit 6118f5e
Copy full SHA for 6118f5e

File tree

7 files changed

+44
-7
lines changed
Filter options

7 files changed

+44
-7
lines changed

‎UPGRADE-4.1.md

Copy file name to clipboard
+13Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
UPGRADE FROM 4.0 to 4.1
2+
=======================
3+
4+
Security
5+
--------
6+
7+
* the `ContextListener::setLogoutOnUserChange()` method is deprecated and will be removed in 5.0
8+
9+
Translation
10+
-----------
11+
12+
* the `FileDumper::setBackup()` method is deprecated and will be removed in 5.0
13+
* the `TranslationWriter::disableBackup()` method is deprecated and will be removed in 5.0

‎UPGRADE-5.0.md

Copy file name to clipboard
+13Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
UPGRADE FROM 4.x to 5.0
2+
=======================
3+
4+
Security
5+
--------
6+
7+
* the `ContextListener::setLogoutOnUserChange()` method has been removed
8+
9+
Translation
10+
-----------
11+
12+
* the `FileDumper::setBackup()` method has been removed
13+
* the `TranslationWriter::disableBackup()` method has been removed

‎src/Symfony/Component/Security/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/Security/CHANGELOG.md
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGELOG
22
=========
33

4+
4.1.0
5+
-----
6+
7+
* the `ContextListener::setLogoutOnUserChange()` method is deprecated and will be removed in 5.0
8+
49
4.0.0
510
-----
611

‎src/Symfony/Component/Security/Http/Firewall/ContextListener.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Security/Http/Firewall/ContextListener.php
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ class ContextListener implements ListenerInterface
4646
private $logoutOnUserChange = true;
4747

4848
/**
49-
* @param TokenStorageInterface $tokenStorage
50-
* @param iterable|UserProviderInterface[] $userProviders
49+
* @param TokenStorageInterface $tokenStorage
50+
* @param iterable|UserProviderInterface[] $userProviders
5151
*/
5252
public function __construct(TokenStorageInterface $tokenStorage, iterable $userProviders, string $contextKey, LoggerInterface $logger = null, EventDispatcherInterface $dispatcher = null, AuthenticationTrustResolverInterface $trustResolver = null)
5353
{
@@ -70,7 +70,7 @@ public function __construct(TokenStorageInterface $tokenStorage, iterable $userP
7070
*/
7171
public function setLogoutOnUserChange($logoutOnUserChange)
7272
{
73-
// no-op, method to be deprecated in 4.1
73+
@trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.', __METHOD__));
7474
}
7575

7676
/**

‎src/Symfony/Component/Translation/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/CHANGELOG.md
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
CHANGELOG
22
=========
33

4+
4.1.0
5+
-----
6+
7+
* the `FileDumper::setBackup()` method is deprecated and will be removed in 5.0
8+
* the `TranslationWriter::disableBackup()` method is deprecated and will be removed in 5.0
9+
410
4.0.0
511
-----
612

‎src/Symfony/Component/Translation/Dumper/FileDumper.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Dumper/FileDumper.php
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,11 @@ public function setRelativePathTemplate($relativePathTemplate)
4949
*/
5050
public function setBackup($backup)
5151
{
52+
@trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.', __METHOD__));
53+
5254
if (false !== $backup) {
5355
throw new \LogicException('The backup feature is no longer supported.');
5456
}
55-
56-
// the method is only present to not break BC
57-
// to be deprecated in 4.1
5857
}
5958

6059
/**

‎src/Symfony/Component/Translation/Writer/TranslationWriter.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Writer/TranslationWriter.php
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ public function addDumper($format, DumperInterface $dumper)
4141
*/
4242
public function disableBackup()
4343
{
44-
// to be deprecated in 4.1
44+
@trigger_error(sprintf('The %s() method is deprecated since 4.1 and will be removed in 5.0.', __METHOD__));
45+
4546
foreach ($this->dumpers as $dumper) {
4647
if (method_exists($dumper, 'setBackup')) {
4748
$dumper->setBackup(false);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.