Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 60ffe2d

Browse filesBrowse files
committed
minor #58516 [MonologBridge] simplify test (xabbuh)
This PR was merged into the 5.4 branch. Discussion ---------- [MonologBridge] simplify test | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT we can simplify the test added in #58492 by dropping the custom exception handler as a triggered deprecation would let the test fail anyway Commits ------- aa9eb60 simplify test
2 parents 61a9137 + aa9eb60 commit 60ffe2d
Copy full SHA for 60ffe2d

File tree

1 file changed

+2
-6
lines changed
Filter options

1 file changed

+2
-6
lines changed

‎src/Symfony/Bridge/Monolog/Tests/Handler/ChromePhpHandlerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Monolog/Tests/Handler/ChromePhpHandlerTest.php
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,15 @@ class ChromePhpHandlerTest extends TestCase
2222
{
2323
public function testOnKernelResponseShouldNotTriggerDeprecation()
2424
{
25+
$this->expectNotToPerformAssertions();
26+
2527
$request = Request::create('/');
2628
$request->headers->remove('User-Agent');
2729

2830
$response = new Response('foo');
2931
$event = new ResponseEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MAIN_REQUEST, $response);
3032

31-
$error = null;
32-
set_error_handler(function ($type, $message) use (&$error) { $error = $message; }, \E_DEPRECATED);
33-
3433
$listener = new ChromePhpHandler();
3534
$listener->onKernelResponse($event);
36-
restore_error_handler();
37-
38-
$this->assertNull($error);
3935
}
4036
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.