symfony
diff --git a/‎src/Symfony/Component/Config/ConfigCacheFactory.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/ConfigCacheFactory.php
+1-5Lines changed: 1 addition & 5 deletions b/‎src/Symfony/Component/Config/ConfigCacheFactory.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/ConfigCacheFactory.php
+1-5Lines changed: 1 addition & 5 deletions
diff --git a/‎src/Symfony/Component/Config/ConfigCacheFactoryInterface.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/ConfigCacheFactoryInterface.php
+1-1Lines changed: 1 addition & 1 deletion b/‎src/Symfony/Component/Config/ConfigCacheFactoryInterface.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/ConfigCacheFactoryInterface.php
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/Symfony/Component/Config/Definition/ArrayNode.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Definition/ArrayNode.php
+1-1Lines changed: 1 addition & 1 deletion b/‎src/Symfony/Component/Config/Definition/ArrayNode.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Definition/ArrayNode.php
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/Symfony/Component/Config/Definition/PrototypeNodeInterface.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Definition/PrototypeNodeInterface.php
-2Lines changed: 0 additions & 2 deletions b/‎src/Symfony/Component/Config/Definition/PrototypeNodeInterface.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Definition/PrototypeNodeInterface.php
-2Lines changed: 0 additions & 2 deletions
diff --git a/‎src/Symfony/Component/Config/FileLocator.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/FileLocator.php
+1-1Lines changed: 1 addition & 1 deletion b/‎src/Symfony/Component/Config/FileLocator.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/FileLocator.php
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/Symfony/Component/Config/ResourceCheckerConfigCacheFactory.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/ResourceCheckerConfigCacheFactory.php
+1-5Lines changed: 1 addition & 5 deletions b/‎src/Symfony/Component/Config/ResourceCheckerConfigCacheFactory.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/ResourceCheckerConfigCacheFactory.php
+1-5Lines changed: 1 addition & 5 deletions
diff --git a/‎src/Symfony/Component/Config/Tests/ConfigCacheFactoryTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Tests/ConfigCacheFactoryTest.php
+8-6Lines changed: 8 additions & 6 deletions b/‎src/Symfony/Component/Config/Tests/ConfigCacheFactoryTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Tests/ConfigCacheFactoryTest.php
+8-6Lines changed: 8 additions & 6 deletions
@@ -35,12 +35,8 @@ public function __construct(bool $debug)
     /**
      * {@inheritdoc}
      */
-    public function cache(string $file, $callback)
+    public function cache(string $file, callable $callback)
     {
-        if (!\is_callable($callback)) {
-            throw new \InvalidArgumentException(sprintf('Invalid type for callback argument. Expected callable, but got "%s".', \gettype($callback)));
-        }
-
         $cache = new ConfigCache($file, $this->debug);
         if (!$cache->isFresh()) {
             $callback($cache);
 
@@ -28,5 +28,5 @@ interface ConfigCacheFactoryInterface
      *
      * @return ConfigCacheInterface The cache instance
      */
-    public function cache(string $file, $callable);
+    public function cache(string $file, callable $callable);
 }
@@ -129,7 +129,7 @@ public function setAllowNewKeys(bool $allow)
      */
     public function setPerformDeepMerging(bool $boolean)
     {
-        $this->performDeepMerging = (bool) $boolean;
+        $this->performDeepMerging = $boolean;
     }
 
     /**
 
@@ -20,8 +20,6 @@ interface PrototypeNodeInterface extends NodeInterface
 {
     /**
      * Sets the name of the node.
-     *
-     * @param string $name The name of the node
      */
     public function setName(string $name);
 }
@@ -33,7 +33,7 @@ public function __construct($paths = [])
     /**
      * {@inheritdoc}
      */
-    public function locate(string $name, string $currentPath = null, $first = true)
+    public function locate(string $name, string $currentPath = null, bool $first = true)
     {
         if ('' == $name) {
             throw new \InvalidArgumentException('An empty file name is not valid to be located.');
 
@@ -32,12 +32,8 @@ public function __construct(iterable $resourceCheckers = [])
     /**
      * {@inheritdoc}
      */
-    public function cache(string $file, $callback)
+    public function cache(string $file, callable $callback)
     {
-        if (!\is_callable($callback)) {
-            throw new \InvalidArgumentException(sprintf('Invalid type for callback argument. Expected callable, but got "%s".', \gettype($callback)));
-        }
-
         $cache = new ResourceCheckerConfigCache($file, $this->resourceCheckers);
         if (!$cache->isFresh()) {
             $callback($cache);
 
@@ -13,17 +13,19 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Config\ConfigCacheFactory;
+use Symfony\Component\Config\ConfigCacheInterface;
+use Symfony\Component\HttpKernel\Tests\CacheWarmer\TestCacheWarmer;
 
 class ConfigCacheFactoryTest extends TestCase
 {
-    /**
-     * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage Invalid type for callback argument. Expected callable, but got "object".
-     */
-    public function testCacheWithInvalidCallback()
+    public function testCanCreateCache()
     {
         $cacheFactory = new ConfigCacheFactory(true);
 
-        $cacheFactory->cache('file', new \stdClass());
+        $cache = $cacheFactory->cache('file', function (ConfigCacheInterface $cache) {
+            return;
+        });
+
+        $this->assertInstanceOf(ConfigCacheInterface::class, $cache);
     }
 }
Original file line number	Diff line number	Diff line change
`@@ -28,5 +28,5 @@ interface ConfigCacheFactoryInterface`
`28`	`28`	`*`
`29`	`29`	`* @return ConfigCacheInterface The cache instance`
`30`	`30`	`*/`
`31`		`- public function cache(string $file, $callable);`
	`31`	`+ public function cache(string $file, callable $callable);`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ public function setAllowNewKeys(bool $allow)`
`129`	`129`	`*/`
`130`	`130`	`public function setPerformDeepMerging(bool $boolean)`
`131`	`131`	`{`
`132`		`- $this->performDeepMerging = (bool) $boolean;`
	`132`	`+ $this->performDeepMerging = $boolean;`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,6 @@ interface PrototypeNodeInterface extends NodeInterface`
`20`	`20`	`{`
`21`	`21`	`/**`
`22`	`22`	`* Sets the name of the node.`
`23`		`- *`
`24`		`- * @param string $name The name of the node`
`25`	`23`	`*/`
`26`	`24`	`public function setName(string $name);`
`27`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,17 +13,19 @@`
`13`	`13`
`14`	`14`	`use PHPUnit\Framework\TestCase;`
`15`	`15`	`use Symfony\Component\Config\ConfigCacheFactory;`
	`16`	`+use Symfony\Component\Config\ConfigCacheInterface;`
	`17`	`+use Symfony\Component\HttpKernel\Tests\CacheWarmer\TestCacheWarmer;`
`16`	`18`
`17`	`19`	`class ConfigCacheFactoryTest extends TestCase`
`18`	`20`	`{`
`19`		`- /**`
`20`		`- * @expectedException \InvalidArgumentException`
`21`		`- * @expectedExceptionMessage Invalid type for callback argument. Expected callable, but got "object".`
`22`		`- */`
`23`		`- public function testCacheWithInvalidCallback()`
	`21`	`+ public function testCanCreateCache()`
`24`	`22`	`{`
`25`	`23`	`$cacheFactory = new ConfigCacheFactory(true);`
`26`	`24`
`27`		`- $cacheFactory->cache('file', new \stdClass());`
	`25`	`+ $cache = $cacheFactory->cache('file', function (ConfigCacheInterface $cache) {`
	`26`	`+ return;`
	`27`	`+ });`
	`28`	`+`
	`29`	`+ $this->assertInstanceOf(ConfigCacheInterface::class, $cache);`
`28`	`30`	`}`
`29`	`31`	`}`