symfony
diff --git a/‎src/Symfony/Component/RateLimiter/Policy/SlidingWindow.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/RateLimiter/Policy/SlidingWindow.php
+7-3Lines changed: 7 additions & 3 deletions b/‎src/Symfony/Component/RateLimiter/Policy/SlidingWindow.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/RateLimiter/Policy/SlidingWindow.php
+7-3Lines changed: 7 additions & 3 deletions
diff --git a/‎src/Symfony/Component/RateLimiter/Tests/Strategy/SlidingWindowTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/RateLimiter/Tests/Strategy/SlidingWindowTest.php
+36Lines changed: 36 additions & 0 deletions b/‎src/Symfony/Component/RateLimiter/Tests/Strategy/SlidingWindowTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/RateLimiter/Tests/Strategy/SlidingWindowTest.php
+36Lines changed: 36 additions & 0 deletions
@@ -63,8 +63,12 @@ public function __construct(string $id, int $intervalInSeconds)
     public static function createFromPreviousWindow(self $window, int $intervalInSeconds): self
     {
         $new = new self($window->id, $intervalInSeconds);
-        $new->hitCountForLastWindow = $window->hitCount;
-        $new->windowEndAt = $window->windowEndAt + $intervalInSeconds;
+        $windowEndAt = $window->windowEndAt + $intervalInSeconds;
+
+        if (time() < $windowEndAt) {
+            $new->hitCountForLastWindow = $window->hitCount;
+            $new->windowEndAt = $windowEndAt;
+        }
 
         return $new;
     }
@@ -112,7 +116,7 @@ public function add(int $hits = 1)
     public function getHitCount(): int
     {
         $startOfWindow = $this->windowEndAt - $this->intervalInSeconds;
-        $percentOfCurrentTimeFrame = (time() - $startOfWindow) / $this->intervalInSeconds;
+        $percentOfCurrentTimeFrame = min((time() - $startOfWindow) / $this->intervalInSeconds, 1);
 
         return (int) floor($this->hitCountForLastWindow * (1 - $percentOfCurrentTimeFrame) + $this->hitCount);
     }
 
@@ -12,9 +12,13 @@
 namespace Symfony\Component\RateLimiter\Tests\Policy;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Bridge\PhpUnit\ClockMock;
 use Symfony\Component\RateLimiter\Exception\InvalidIntervalException;
 use Symfony\Component\RateLimiter\Policy\SlidingWindow;
 
+/**
+ * @group time-sensitive
+ */
 class SlidingWindowTest extends TestCase
 {
     public function testGetExpirationTime()
@@ -36,4 +40,36 @@ public function testInvalidInterval()
         $this->expectException(InvalidIntervalException::class);
         new SlidingWindow('foo', 0);
     }
+
+    public function testLongInterval()
+    {
+        ClockMock::register(SlidingWindow::class);
+        $window = new SlidingWindow('foo', 60);
+        $this->assertSame(0, $window->getHitCount());
+        $window->add(20);
+        $this->assertSame(20, $window->getHitCount());
+
+        sleep(60);
+        $new = SlidingWindow::createFromPreviousWindow($window, 60);
+        $this->assertSame(20, $new->getHitCount());
+
+        sleep(30);
+        $this->assertSame(10, $new->getHitCount());
+
+        sleep(30);
+        $this->assertSame(0, $new->getHitCount());
+
+        sleep(30);
+        $this->assertSame(0, $new->getHitCount());
+    }
+
+    public function testLongIntervalCreate()
+    {
+        ClockMock::register(SlidingWindow::class);
+        $window = new SlidingWindow('foo', 60);
+
+        sleep(300);
+        $new = SlidingWindow::createFromPreviousWindow($window, 60);
+        $this->assertFalse($new->isExpired());
+    }
 }
Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,12 @@ public function __construct(string $id, int $intervalInSeconds)`
`63`	`63`	`public static function createFromPreviousWindow(self $window, int $intervalInSeconds): self`
`64`	`64`	`{`
`65`	`65`	`$new = new self($window->id, $intervalInSeconds);`
`66`		`- $new->hitCountForLastWindow = $window->hitCount;`
`67`		`- $new->windowEndAt = $window->windowEndAt + $intervalInSeconds;`
	`66`	`+ $windowEndAt = $window->windowEndAt + $intervalInSeconds;`
	`67`	`+`
	`68`	`+ if (time() < $windowEndAt) {`
	`69`	`+ $new->hitCountForLastWindow = $window->hitCount;`
	`70`	`+ $new->windowEndAt = $windowEndAt;`
	`71`	`+ }`
`68`	`72`
`69`	`73`	`return $new;`
`70`	`74`	`}`
`@@ -112,7 +116,7 @@ public function add(int $hits = 1)`
`112`	`116`	`public function getHitCount(): int`
`113`	`117`	`{`
`114`	`118`	`$startOfWindow = $this->windowEndAt - $this->intervalInSeconds;`
`115`		`- $percentOfCurrentTimeFrame = (time() - $startOfWindow) / $this->intervalInSeconds;`
	`119`	`+ $percentOfCurrentTimeFrame = min((time() - $startOfWindow) / $this->intervalInSeconds, 1);`
`116`	`120`
`117`	`121`	`return (int) floor($this->hitCountForLastWindow * (1 - $percentOfCurrentTimeFrame) + $this->hitCount);`
`118`	`122`	`}`