Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 53a45b2

Browse filesBrowse files
committed
bug #44467 [Console] Fix parameter types for ProcessHelper::mustRun() (derrabus)
This PR was merged into the 4.4 branch. Discussion ---------- [Console] Fix parameter types for `ProcessHelper::mustRun()` | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A The `mustRun()` method wraps the `run()` method and therefor must accepts the same parameter types. However, `mustRun()` claims to accept a string as `$cmd` while `run()` requires it to be an array. This PR fixes the incorrect doc block. Commits ------- c1c8c20 Fix parameter types for ProcessHelper::mustRun()
2 parents c33a1fa + c1c8c20 commit 53a45b2
Copy full SHA for 53a45b2

File tree

1 file changed

+4
-4
lines changed
Filter options

1 file changed

+4
-4
lines changed

‎src/Symfony/Component/Console/Helper/ProcessHelper.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Helper/ProcessHelper.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,10 @@ public function run(OutputInterface $output, $cmd, $error = null, callable $call
9595
* This is identical to run() except that an exception is thrown if the process
9696
* exits with a non-zero exit code.
9797
*
98-
* @param string|Process $cmd An instance of Process or a command to run
99-
* @param string|null $error An error message that must be displayed if something went wrong
100-
* @param callable|null $callback A PHP callback to run whenever there is some
101-
* output available on STDOUT or STDERR
98+
* @param array|Process $cmd An instance of Process or a command to run
99+
* @param string|null $error An error message that must be displayed if something went wrong
100+
* @param callable|null $callback A PHP callback to run whenever there is some
101+
* output available on STDOUT or STDERR
102102
*
103103
* @return Process The process that ran
104104
*

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.