Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 51f01bd

Browse filesBrowse files
committed
minor #32267 [FrameworkBundle] deprecate the framework.templating option (xabbuh)
This PR was merged into the 4.3 branch. Discussion ---------- [FrameworkBundle] deprecate the framework.templating option | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32120 | License | MIT | Doc PR | The config node has already been removed in the `master` branch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix. Commits ------- ba241ce deprecate the framework.templating option
2 parents 6bf5d8f + ba241ce commit 51f01bd
Copy full SHA for 51f01bd

File tree

6 files changed

+11
-1
lines changed
Filter options

6 files changed

+11
-1
lines changed

‎UPGRADE-4.3.md

Copy file name to clipboardExpand all lines: UPGRADE-4.3.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ Form
7777
FrameworkBundle
7878
---------------
7979

80+
* Deprecated the `framework.templating` option, use Twig instead.
8081
* Not passing the project directory to the constructor of the `AssetsInstallCommand` is deprecated. This argument will
8182
be mandatory in 5.0.
8283
* Deprecated the "Psr\SimpleCache\CacheInterface" / "cache.app.simple" service, use "Symfony\Contracts\Cache\CacheInterface" / "cache.app" instead.

‎UPGRADE-5.0.md

Copy file name to clipboardExpand all lines: UPGRADE-5.0.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,8 @@ Form
169169
FrameworkBundle
170170
---------------
171171

172+
* Remved the `framework.templating` option, use Twig instead.
172173
* The project dir argument of the constructor of `AssetsInstallCommand` is required.
173-
174174
* Removed support for `bundle:controller:action` syntax to reference controllers. Use `serviceOrFqcn::method`
175175
instead where `serviceOrFqcn` is either the service ID when using controllers as services or the FQCN of the controller.
176176

‎src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ CHANGELOG
44
4.3.0
55
-----
66

7+
* Deprecated the `framework.templating` option, use Twig instead.
78
* Added `WebTestAssertionsTrait` (included by default in `WebTestCase`)
89
* Renamed `Client` to `KernelBrowser`
910
* Not passing the project directory to the constructor of the `AssetsInstallCommand` is deprecated. This argument will

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ private function addTemplatingSection(ArrayNodeDefinition $rootNode)
605605
->arrayNode('templating')
606606
->info('templating configuration')
607607
->canBeEnabled()
608+
->setDeprecated('The "%path%.%node%" configuration is deprecated since Symfony 4.3. Use the "twig" service directly instead.')
608609
->beforeNormalization()
609610
->ifTrue(function ($v) { return false === $v || \is_array($v) && false === $v['enabled']; })
610611
->then(function () { return ['enabled' => false, 'engines' => false]; })

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ public function testDefaultConfig()
3535
);
3636
}
3737

38+
/**
39+
* @group legacy
40+
*/
3841
public function testDoNoDuplicateDefaultFormResources()
3942
{
4043
$input = ['templating' => [

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,9 @@ public function testTemplating()
602602
$this->assertEquals('global_hinclude_template', $container->getParameter('fragment.renderer.hinclude.global_template'), '->registerTemplatingConfiguration() registers the global hinclude.js template');
603603
}
604604

605+
/**
606+
* @group legacy
607+
*/
605608
public function testTemplatingCanBeDisabled()
606609
{
607610
$container = $this->createContainerFromFile('templating_disabled');
@@ -867,6 +870,7 @@ public function testTranslatorMultipleFallbacks()
867870
}
868871

869872
/**
873+
* @group legacy
870874
* @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
871875
*/
872876
public function testTemplatingRequiresAtLeastOneEngine()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.