Commit 509d952
committed
minor #29602 [DX] rename unit test controller (frankdejonge)
This PR was merged into the 3.4 branch.
Discussion
----------
[DX] rename unit test controller
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? |no
| New feature? |no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Whenever I create a new controller the actually needed controller shows up second in the list of auto-completion. The first suggestion is a class defined in the test and should not ever be extended in the application. This PR renames it so that doesn't happen anymore.
Example of the autocomplete issue:
<img width="748" alt="screenshot 2018-12-14 at 10 33 26" src="https://user-images.githubusercontent.com/534693/49995500-a09dca80-ff8c-11e8-80b5-18890ff058b1.png">
Commits
-------
d4e426c Renamed test controller from Controller to TestController so it doesn't show up in the IDE autocomplete.File tree
Expand file treeCollapse file tree
1 file changed
+4
-4
lines changedOpen diff view settings
Filter options
- src/Symfony/Component/HttpKernel/Tests
Expand file treeCollapse file tree
1 file changed
+4
-4
lines changedOpen diff view settings
Collapse file
src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php+4-4Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
200 | 200 | |
201 | 201 | |
202 | 202 | |
203 | | - |
| 203 | + |
204 | 204 | |
205 | 205 | |
206 | 206 | |
| ||
216 | 216 | |
217 | 217 | |
218 | 218 | |
219 | | - |
| 219 | + |
220 | 220 | |
221 | 221 | |
222 | 222 | |
223 | 223 | |
224 | 224 | |
225 | 225 | |
226 | 226 | |
227 | | - |
| 227 | + |
228 | 228 | |
229 | 229 | |
230 | 230 | |
| ||
381 | 381 | |
382 | 382 | |
383 | 383 | |
384 | | - |
| 384 | + |
385 | 385 | |
386 | 386 | |
387 | 387 | |
|
0 commit comments