Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 48093f4

Browse filesBrowse files
Fix reporting unsilenced deprecations from insulated tests
1 parent db91042 commit 48093f4
Copy full SHA for 48093f4

File tree

Expand file treeCollapse file tree

2 files changed

+4
-2
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-2
lines changed

‎src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,8 @@ public function endTest($test, $time)
284284
foreach ($deprecations ? unserialize($deprecations) : array() as $deprecation) {
285285
$error = serialize(array('deprecation' => $deprecation[1], 'class' => $className, 'method' => $test->getName(false), 'triggering_file' => isset($deprecation[2]) ? $deprecation[2] : null));
286286
if ($deprecation[0]) {
287-
@trigger_error($error, E_USER_DEPRECATED);
287+
// unsilenced on purpose
288+
trigger_error($error, E_USER_DEPRECATED);
288289
} else {
289290
@trigger_error($error, E_USER_DEPRECATED);
290291
}

‎src/Symfony/Component/BrowserKit/Client.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/BrowserKit/Client.php
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,8 @@ protected function doRequestInProcess($request)
361361
unlink($deprecationsFile);
362362
foreach ($deprecations ? unserialize($deprecations) : [] as $deprecation) {
363363
if ($deprecation[0]) {
364-
@trigger_error($deprecation[1], E_USER_DEPRECATED);
364+
// unsilenced on purpose
365+
trigger_error($deprecation[1], E_USER_DEPRECATED);
365366
} else {
366367
@trigger_error($deprecation[1], E_USER_DEPRECATED);
367368
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.