Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 460adb0

Browse filesBrowse files
Merge branch '7.4' into 8.0
* 7.4: [DependencyInjection] Skip validating deprecated aliases in CheckAliasValidityPass
2 parents 7529a09 + 1097b1e commit 460adb0
Copy full SHA for 460adb0

2 files changed

+12-1Lines changed: 12 additions & 1 deletion

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/Symfony/Component/DependencyInjection/Compiler/CheckAliasValidityPass.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Compiler/CheckAliasValidityPass.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public function process(ContainerBuilder $container): void
2525
{
2626
foreach ($container->getAliases() as $id => $alias) {
2727
try {
28-
if (!$container->hasDefinition((string) $alias)) {
28+
if ($alias->isDeprecated() || !$container->hasDefinition((string) $alias)) {
2929
continue;
3030
}
3131

Collapse file

‎src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckAliasValidityPassTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckAliasValidityPassTest.php
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,17 @@ public function testProcessIgnoresTargetWithoutClass()
7272
$this->addToAssertionCount(1);
7373
}
7474

75+
public function testProcessIgnoresDeprecatedAlias()
76+
{
77+
$container = new ContainerBuilder();
78+
$container->register('a')->setClass(FooNotImplementing::class);
79+
$container->setAlias(FooInterface::class, 'a')
80+
->setDeprecated('vendor/package', '1.2', 'The "%alias_id%" alias is deprecated.');
81+
82+
$this->process($container);
83+
$this->addToAssertionCount(1);
84+
}
85+
7586
protected function process(ContainerBuilder $container): void
7687
{
7788
$pass = new CheckAliasValidityPass();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.