symfony
diff --git a/‎src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
+4-1Lines changed: 4 additions & 1 deletion b/‎src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
+4-1Lines changed: 4 additions & 1 deletion
diff --git a/‎src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php
+27Lines changed: 27 additions & 0 deletions b/‎src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Serializer/Tests/Encoder/XmlEncoderTest.php
+27Lines changed: 27 additions & 0 deletions
@@ -143,10 +143,13 @@ public function decode($data, $format, array $context = [])
         $rootNode = null;
         $decoderIgnoredNodeTypes = $context[self::DECODER_IGNORED_NODE_TYPES] ?? $this->defaultContext[self::DECODER_IGNORED_NODE_TYPES];
         foreach ($dom->childNodes as $child) {
+            if (\in_array($child->nodeType, $decoderIgnoredNodeTypes, true)) {
+                continue;
+            }
             if (\XML_DOCUMENT_TYPE_NODE === $child->nodeType) {
                 throw new NotEncodableValueException('Document types are not allowed.');
             }
-            if (!$rootNode && !\in_array($child->nodeType, $decoderIgnoredNodeTypes, true)) {
+            if (!$rootNode) {
                 $rootNode = $child;
             }
         }
 
@@ -591,6 +591,33 @@ public function testDecodeIgnoreComments()
         $this->assertEquals($expected, $this->encoder->decode($source, 'xml'));
     }
 
+    public function testDecodeIgnoreDocumentType()
+    {
+        $source = <<<'XML'
+<?xml version="1.0"?>
+<!DOCTYPE people>
+<people>
+    <person>
+        <firstname>Benjamin</firstname>
+        <lastname>Alexandre</lastname>
+    </person>
+    <person>
+        <firstname>Damien</firstname>
+        <lastname>Clay</lastname>
+    </person>
+</people>
+XML;
+        $expected = ['person' => [
+          ['firstname' => 'Benjamin', 'lastname' => 'Alexandre'],
+          ['firstname' => 'Damien', 'lastname' => 'Clay'],
+        ]];
+        $this->assertEquals($expected, $this->encoder->decode(
+            $source,
+            'xml',
+            [XmlEncoder::DECODER_IGNORED_NODE_TYPES => [\XML_DOCUMENT_TYPE_NODE]]
+        ));
+    }
+
     public function testDecodePreserveComments()
     {
         $this->doTestDecodePreserveComments();
Original file line number	Diff line number	Diff line change
`@@ -143,10 +143,13 @@ public function decode($data, $format, array $context = [])`
`143`	`143`	`$rootNode = null;`
`144`	`144`	`$decoderIgnoredNodeTypes = $context[self::DECODER_IGNORED_NODE_TYPES] ?? $this->defaultContext[self::DECODER_IGNORED_NODE_TYPES];`
`145`	`145`	`foreach ($dom->childNodes as $child) {`
	`146`	`+ if (\in_array($child->nodeType, $decoderIgnoredNodeTypes, true)) {`
	`147`	`+ continue;`
	`148`	`+ }`
`146`	`149`	`if (\XML_DOCUMENT_TYPE_NODE === $child->nodeType) {`
`147`	`150`	`throw new NotEncodableValueException('Document types are not allowed.');`
`148`	`151`	`}`
`149`		`- if (!$rootNode && !\in_array($child->nodeType, $decoderIgnoredNodeTypes, true)) {`
	`152`	`+ if (!$rootNode) {`
`150`	`153`	`$rootNode = $child;`
`151`	`154`	`}`
`152`	`155`	`}`