Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 40d133c

Browse filesBrowse files
Merge branch '3.2'
* 3.2: [VarDumper] ExceptionCaster robustness fix
2 parents dc52a3f + 5676526 commit 40d133c
Copy full SHA for 40d133c

File tree

2 files changed

+1
-2
lines changed
Filter options

2 files changed

+1
-2
lines changed

‎src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1372,7 +1372,6 @@ public function testSubmitMultipleChoicesInts()
13721372
$form = $this->factory->create(static::TESTED_TYPE, null, array(
13731373
'multiple' => true,
13741374
'choices' => array_flip($this->numericChoicesFlipped),
1375-
'choices_as_values' => true,
13761375
));
13771376

13781377
$form->submit(array(1, 2));

‎src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public static function castThrowingCasterException(ThrowingCasterException $e, a
6767
$prefix = Caster::PREFIX_PROTECTED;
6868
$xPrefix = "\0Exception\0";
6969

70-
if (isset($a[$xPrefix.'previous'], $a[$xPrefix.'trace'])) {
70+
if (isset($a[$xPrefix.'previous'], $a[$xPrefix.'trace']) && $a[$xPrefix.'previous'] instanceof \Exception) {
7171
$b = (array) $a[$xPrefix.'previous'];
7272
self::traceUnshift($b[$xPrefix.'trace'], get_class($a[$xPrefix.'previous']), $b[$prefix.'file'], $b[$prefix.'line']);
7373
$a[$xPrefix.'trace'] = new TraceStub($b[$xPrefix.'trace'], false, 0, -count($a[$xPrefix.'trace']->value));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.