Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3fb8edd

Browse filesBrowse files
committed
fix deprecation triggering test detection
1 parent be9382a commit 3fb8edd
Copy full SHA for 3fb8edd

File tree

Expand file treeCollapse file tree

2 files changed

+20
-6
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+20
-6
lines changed

‎src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
+18-4Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,16 @@ public static function register($mode = 0)
116116
}
117117

118118
if (isset($trace[$i]['object']) || isset($trace[$i]['class'])) {
119-
$class = isset($trace[$i]['object']) ? get_class($trace[$i]['object']) : $trace[$i]['class'];
120-
$method = $trace[$i]['function'];
121-
$Test = $UtilPrefix.'Test';
119+
if (isset($trace[$i]['class']) && 'Symfony\Bridge\PhpUnit\SymfonyTestsListener' === $trace[$i]['class']) {
120+
$parsedMsg = unserialize($msg);
121+
$msg = $parsedMsg['deprecation'];
122+
$class = $parsedMsg['class'];
123+
$method = $parsedMsg['method'];
124+
} else {
125+
$class = isset($trace[$i]['object']) ? get_class($trace[$i]['object']) : $trace[$i]['class'];
126+
$method = $trace[$i]['function'];
127+
$Test = $UtilPrefix.'Test';
128+
}
122129

123130
if (0 !== error_reporting()) {
124131
$group = 'unsilenced';
@@ -245,7 +252,14 @@ public static function collectDeprecations($outputFile)
245252
if (E_USER_DEPRECATED !== $type && E_DEPRECATED !== $type) {
246253
return $previousErrorHandler ? $previousErrorHandler($type, $msg, $file, $line, $context) : false;
247254
}
248-
$deprecations[] = array(error_reporting(), $msg);
255+
$trace = debug_backtrace(true);
256+
$i = count($trace);
257+
while (1 < $i && (!isset($trace[--$i]['class']) || ('ReflectionMethod' === $trace[$i]['class'] || 0 === strpos($trace[$i]['class'], 'PHPUnit_') || 0 === strpos($trace[$i]['class'], 'PHPUnit\\')))) {
258+
// No-op
259+
}
260+
$class = isset($trace[$i]['object']) ? get_class($trace[$i]['object']) : $trace[$i]['class'];
261+
$method = $trace[$i]['function'];
262+
$deprecations[] = array(error_reporting(), $msg, $class, $method);
249263
});
250264
register_shutdown_function(function () use ($outputFile, &$deprecations) {
251265
file_put_contents($outputFile, serialize($deprecations));

‎src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Legacy/SymfonyTestsListenerTrait.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,9 +264,9 @@ public function endTest($test, $time)
264264
unlink($this->runsInSeparateProcess);
265265
foreach ($deprecations ? unserialize($deprecations) : array() as $deprecation) {
266266
if ($deprecation[0]) {
267-
trigger_error($deprecation[1], E_USER_DEPRECATED);
267+
trigger_error(serialize(array('deprecation' => $deprecation[1], 'class' => $deprecation[2], 'method' => $deprecation[3])), E_USER_DEPRECATED);
268268
} else {
269-
@trigger_error($deprecation[1], E_USER_DEPRECATED);
269+
@trigger_error(serialize(array('deprecation' => $deprecation[1], 'class' => $deprecation[2], 'method' => $deprecation[3])), E_USER_DEPRECATED);
270270
}
271271
}
272272
$this->runsInSeparateProcess = false;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.