Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3f75092

Browse filesBrowse files
committed
minor #30839 Skip Glob brace test when GLOB_BRACE is unavailable (wouterj)
This PR was merged into the 3.4 branch. Discussion ---------- Skip Glob brace test when GLOB_BRACE is unavailable | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | n/a From [PHP.net](https://www.php.net/glob): > Note: The GLOB_BRACE flag is not available on some non GNU systems, like Solaris. This means running the testsuite in e.g. a php-alpine container fails atm. This test should be skipped in these environments. Commits ------- ce38fe3 Skip Glob brace test when GLOB_BRACE is unavailable
2 parents 668f585 + ce38fe3 commit 3f75092
Copy full SHA for 3f75092

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed

‎src/Symfony/Component/Finder/Tests/FinderTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Finder/Tests/FinderTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,10 @@ public function testInWithNonDirectoryGlob()
339339

340340
public function testInWithGlobBrace()
341341
{
342+
if (!\defined('GLOB_BRACE')) {
343+
$this->markTestSkipped('Glob brace is not supported on this system.');
344+
}
345+
342346
$finder = $this->buildFinder();
343347
$finder->in([__DIR__.'/Fixtures/{A,copy/A}/B/C'])->getIterator();
344348

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.