Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3af6406

Browse filesBrowse files
author
Robin Chalas
committed
minor #30406 Removed non-existing parameters for LogoutUrlGenerator calls (King2500)
This PR was squashed before being merged into the 3.4 branch (closes #30406). Discussion ---------- Removed non-existing parameters for LogoutUrlGenerator calls | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Is there a reason these arguments are in place, though they dont actually exist as parameters for `LogoutUrlGenerator::getLogoutPath` and `::getLogoutUrl`? see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php#L76 and https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php#L88 If there is no reason, this PR can be merged, because this parameter makes no sense there. ;-) Commits ------- d3ee2b6 Removed non-existing parameters for LogoutUrlGenerator calls
2 parents c8d6dec + d3ee2b6 commit 3af6406
Copy full SHA for 3af6406

File tree

Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed

‎src/Symfony/Bundle/SecurityBundle/Templating/Helper/LogoutUrlHelper.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/SecurityBundle/Templating/Helper/LogoutUrlHelper.php
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace Symfony\Bundle\SecurityBundle\Templating\Helper;
1313

14-
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
1514
use Symfony\Component\Security\Http\Logout\LogoutUrlGenerator;
1615
use Symfony\Component\Templating\Helper\Helper;
1716

@@ -38,7 +37,7 @@ public function __construct(LogoutUrlGenerator $generator)
3837
*/
3938
public function getLogoutPath($key)
4039
{
41-
return $this->generator->getLogoutPath($key, UrlGeneratorInterface::ABSOLUTE_PATH);
40+
return $this->generator->getLogoutPath($key);
4241
}
4342

4443
/**
@@ -50,7 +49,7 @@ public function getLogoutPath($key)
5049
*/
5150
public function getLogoutUrl($key)
5251
{
53-
return $this->generator->getLogoutUrl($key, UrlGeneratorInterface::ABSOLUTE_URL);
52+
return $this->generator->getLogoutUrl($key);
5453
}
5554

5655
/**

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.