Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 385efaf

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
minor #59820 [DependencyInjection] Fix phpdoc for $configurator in Autoconfigure attribute (jfranclin)
This PR was merged into the 7.2 branch. Discussion ---------- [DependencyInjection] Fix phpdoc for $configurator in Autoconfigure attribute | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59821 | License | MIT Since SF7.1, in Autoconfigure attribute, the $configurator phpdoc seems wrong : ` * `@param` array<class-string, string>|string|null $configurator A PHP function, reference or an array containing a class/Reference and a method to call after the service is fully initialized` The doc is asking for a class-string **key** and a string **value**. However, this is not always the case because the first parameter could be a service, like ``@foo`` which is not a class-string. Moreover, the second parameter should not be empty. Commits ------- ce03562 [DependencyInjection] Fix phpdoc for $configurator in Autoconfigure attribute
2 parents 33f70b7 + ce03562 commit 385efaf
Copy full SHA for 385efaf

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/DependencyInjection/Attribute/Autoconfigure.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Attribute/Autoconfigure.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class Autoconfigure
2828
* @param bool|null $shared Whether to declare the service as shared
2929
* @param bool|null $autowire Whether to declare the service as autowired
3030
* @param array<string, mixed>|null $properties The properties to define when creating the service
31-
* @param array<class-string, string>|string|null $configurator A PHP function, reference or an array containing a class/Reference and a method to call after the service is fully initialized
31+
* @param array{string, string}|string|null $configurator A PHP function, reference or an array containing a class/reference and a method to call after the service is fully initialized
3232
* @param string|null $constructor The public static method to use to instantiate the service
3333
*/
3434
public function __construct(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.