Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3825542

Browse filesBrowse files
committed
minor #38168 [HttpFoundation] Skip the cookie_max_age fixture on PHP 8 (derrabus)
This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Skip the cookie_max_age fixture on PHP 8 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A This PR suggest to skip a certain integration test on php 8. The integration test in question triggers a warning by setting a way too high expiration date when calling `setcookie()`. Apparently, this warning has been upgraded to a fatal error on php 8. Since the integration test is run in a separate process, we might as well adjust the expectation of that test case, but I don't really see the point in asserting fatal error behavior, to be honest. Commits ------- d6d9b29 [HttpFoundation] Skip the cookie_max_age fixture on PHP 8.
2 parents 4b3015f + d6d9b29 commit 3825542
Copy full SHA for 3825542

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed

‎src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ public static function tearDownAfterClass()
4545
*/
4646
public function testCookie($fixture)
4747
{
48+
if (\PHP_VERSION_ID >= 80000 && 'cookie_max_age' === $fixture) {
49+
$this->markTestSkipped('This fixture produces a fatal error on PHP 8.');
50+
}
51+
4852
$result = file_get_contents(sprintf('http://localhost:8054/%s.php', $fixture));
4953
$this->assertStringMatchesFormatFile(__DIR__.sprintf('/Fixtures/response-functional/%s.expected', $fixture), $result);
5054
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.