Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 3653836

Browse filesBrowse files
fabpotfabpot
committed
bug #37429 [DI] fix parsing of argument type=binary in xml (Tobion)
This PR was merged into the 4.4 branch. Discussion ---------- [DI] fix parsing of argument type=binary in xml | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | Parameters and arguments can be of type="binary" since #25928. But the XSD forgot to be updated for arguments. So if you try to run `bin/console debug:container` you'd get an error like ``` In XmlFileLoader.php line 385: Unable to parse file "var/cache/dev/App_KernelDevDebugContainer.xml": [ERROR 1840] Element '{ht tp://symfony.com/schema/dic/services}argument', attribute 'type': [facet 'enumeration'] The value 'binary' is not a n element of the set {'abstract', 'collection', 'service', 'expression', 'string', 'constant', 'iterator', 'service _locator', 'tagged', 'tagged_iterator', 'tagged_locator'}. (in /home/benny/project/ - line 505, column 0) [ERROR 1824] Element '{http://symfony.com/schema/dic/services}argument', attribute 'type': 'binary' is not a valid value of the atomic type '{http://symfony.com/schema/dic/services}argument_type'. (in /home/benny/project/ - line 5 05, column 0)` ``` Commits ------- 70b6a00 [DI] fix parsing of argument type=binary in xml
2 parents 73596ef + 70b6a00 commit 3653836
Copy full SHA for 3653836

File tree

1 file changed

+1
-0
lines changed
Filter options
  • src/Symfony/Component/DependencyInjection/Loader/schema/dic/services

1 file changed

+1
-0
lines changed

‎src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@
265265
<xsd:enumeration value="expression" />
266266
<xsd:enumeration value="string" />
267267
<xsd:enumeration value="constant" />
268+
<xsd:enumeration value="binary" />
268269
<xsd:enumeration value="iterator" />
269270
<xsd:enumeration value="service_locator" />
270271
<!-- "tagged" is an alias of "tagged_iterator", using "tagged_iterator" is preferred. -->

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.