Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 352997e

Browse filesBrowse files
committed
minor #18664 [Form] [DoctrineBridge] updated changelogs after #18359 (HeahDude)
This PR was merged into the 3.1-dev branch. Discussion ---------- [Form] [DoctrineBridge] updated changelogs after #18359 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ follows #18359. Commits ------- 1c8dc9d [Form] [DoctrineBridge] updated changelogs after #18359
2 parents 731d7a6 + 1c8dc9d commit 352997e
Copy full SHA for 352997e

File tree

5 files changed

+9
-7
lines changed
Filter options

5 files changed

+9
-7
lines changed

‎UPGRADE-3.1.md

Copy file name to clipboardExpand all lines: UPGRADE-3.1.md
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ Form
3939
'choice_label' => function ($choice) {
4040
return strtoupper($choice);
4141
},
42-
```
42+
```
43+
44+
* Caching of the loaded `ChoiceListInterface` in the `LazyChoiceList` has been deprecated,
45+
it must be cached in the `ChoiceLoaderInterface` implementation instead.
4346

4447
FrameworkBundle
4548
---------------

‎UPGRADE-4.0.md

Copy file name to clipboardExpand all lines: UPGRADE-4.0.md
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ Form
3636
},
3737
```
3838

39+
* Caching of the loaded `ChoiceListInterface` in the `LazyChoiceList` has been removed,
40+
it must be cached in the `ChoiceLoaderInterface` implementation instead.
3941

4042
FrameworkBundle
4143
---------------

‎src/Symfony/Bridge/Doctrine/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Doctrine/CHANGELOG.md
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ CHANGELOG
77
* added "{{ value }}" message placeholder to UniqueEntityValidator
88
* deprecated `MergeDoctrineCollectionListener::onBind` in favor of
99
`MergeDoctrineCollectionListener::onSubmit`
10+
* deprecated passing `ChoiceListFactoryInterface` as first argument of
11+
`DoctrineChoiceLoader`'s constructor
1012

1113
3.0.0
1214
-----

‎src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@
2424
*/
2525
class DoctrineChoiceLoader implements ChoiceLoaderInterface
2626
{
27-
/**
28-
* @var ChoiceListFactoryInterface
29-
*/
30-
private $factory;
31-
3227
/**
3328
* @var ObjectManager
3429
*/
@@ -78,7 +73,6 @@ public function __construct($manager, $class, $idReader = null, $objectLoader =
7873

7974
// Provide a BC layer since $factory has changed
8075
// form first to last argument as of 3.1
81-
$this->factory = $manager;
8276
$manager = $class;
8377
$class = $idReader;
8478
$objectLoader = $factory;

‎src/Symfony/Component/Form/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/Form/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ CHANGELOG
1010
* Using callable strings as choice options in `ChoiceType` has been deprecated
1111
and will be used as `PropertyPath` instead of callable in Symfony 4.0.
1212
* implemented `DataTransformerInterface` in `TextType`
13+
* deprecated caching loaded choice list in `LazyChoiceList::$loadedList`
1314

1415
3.0.0
1516
-----

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.