symfony
diff --git a/‎src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeHintsPassTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeHintsPassTest.php
+59Lines changed: 59 additions & 0 deletions b/‎src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeHintsPassTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeHintsPassTest.php
+59Lines changed: 59 additions & 0 deletions
diff --git a/‎src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeHintsPass/Foo.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeHintsPass/Foo.php
+5Lines changed: 5 additions & 0 deletions b/‎src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeHintsPass/Foo.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Fixtures/CheckTypeHintsPass/Foo.php
+5Lines changed: 5 additions & 0 deletions
@@ -296,6 +296,65 @@ public function testProcessFactoryWhithClassName()
         $this->assertInstanceOf(Bar::class, $container->get(Bar::class));
     }
 
+    /**
+     * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
+     * @expectedExceptionMessage In service declaration "bar". Trying to inject a "Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeHintsPass\Foo" as argument 0 of "Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeHintsPass\Foo::createBarArguments", but the type hint expects a "stdClass"
+     */
+    public function testProcessFactoryFailsOnInvalidParameterType()
+    {
+        $container = new ContainerBuilder();
+
+        $container->register('foo', Foo::class);
+        $container->register('bar', Bar::class)
+            ->addArgument(new Reference('foo'))
+            ->setFactory(array(
+                new Reference('foo'),
+                'createBarArguments',
+            ));
+
+        (new CheckTypeHintsPass(true))->process($container);
+    }
+
+    /**
+     * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
+     * @expectedExceptionMessage In service declaration "bar". Trying to inject a "Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeHintsPass\Foo" as argument 1 of "Symfony\Component\DependencyInjection\Tests\Fixtures\CheckTypeHintsPass\Foo::createBarArguments", but the type hint expects a "stdClass"
+     */
+    public function testProcessFactoryFailsOnInvalidParameterTypeOptional()
+    {
+        $container = new ContainerBuilder();
+
+        $container->register('stdClass', \stdClass::class);
+        $container->register('foo', Foo::class);
+        $container->register('bar', Bar::class)
+            ->addArgument(new Reference('stdClass'))
+            ->addArgument(new Reference('foo'))
+            ->setFactory(array(
+                new Reference('foo'),
+                'createBarArguments',
+            ));
+
+        (new CheckTypeHintsPass(true))->process($container);
+    }
+
+    public function testProcessFactorySuccessOnValidTypes()
+    {
+        $container = new ContainerBuilder();
+
+        $container->register('stdClass', \stdClass::class);
+        $container->register('foo', Foo::class);
+        $container->register('bar', Bar::class)
+            ->addArgument(new Reference('stdClass'))
+            ->addArgument(new Reference('stdClass'))
+            ->setFactory(array(
+                new Reference('foo'),
+                'createBarArguments',
+            ));
+
+        (new CheckTypeHintsPass(true))->process($container);
+
+        $this->addToAssertionCount(1);
+    }
+
     public function testProcessDoesNotLoadCodeByDefault()
     {
         $container = new ContainerBuilder();
 
@@ -8,4 +8,9 @@ public static function createBar()
     {
         return new Bar(new \stdClass());
     }
+
+    public static function createBarArguments(\stdClass $stdClass, \stdClass $stdClassOptional = null)
+    {
+        return new Bar($stdClass);
+    }
 }
Original file line number	Diff line number	Diff line change
`@@ -8,4 +8,9 @@ public static function createBar()`
`8`	`8`	`{`
`9`	`9`	`return new Bar(new \stdClass());`
`10`	`10`	`}`
	`11`	`+`
	`12`	`+ public static function createBarArguments(\stdClass $stdClass, \stdClass $stdClassOptional = null)`
	`13`	`+ {`
	`14`	`+ return new Bar($stdClass);`
	`15`	`+ }`
`11`	`16`	`}`