Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2e7e0ee

Browse filesBrowse files
committed
minor #50752 [WebProfilerBundle] Fix the accessibility of some background color (javiereguiluz)
This PR was merged into the 6.2 branch. Discussion ---------- [WebProfilerBundle] Fix the accessibility of some background color | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | #48961 is a great PR that fixes some small issues in the toolbar. However, I'm worried about one of its changes. Instead of using the custom green color defined for the toolbar, it now uses one of the green colors used in the profiler. The result is that now the profiler has a too low contrast ratio: <img width="357" alt="before" src="https://github.com/symfony/symfony/assets/73419/57d634db-ed47-425a-a88e-4346d84bdcbd"> This PR restores the original green color, which looks like this: <img width="362" alt="after" src="https://github.com/symfony/symfony/assets/73419/371c4bba-7412-4bd5-aca2-c58018923159"> <img width="293" alt="after-server" src="https://github.com/symfony/symfony/assets/73419/b341d83d-38d3-4422-849b-1816444916ac"> Commits ------- 99736d3 [WebProfilerBundle] Fix the accessibility of some background color
2 parents 6369e0e + 99736d3 commit 2e7e0ee
Copy full SHA for 2e7e0ee

File tree

1 file changed

+3
-3
lines changed
Filter options

1 file changed

+3
-3
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
--sf-toolbar-green-100: #deeaea;
3939
--sf-toolbar-green-200: #bbd5d5;
4040
--sf-toolbar-green-300: #99bfbf;
41-
--sf-toolbar-green-400: #1dc9a4;
41+
--sf-toolbar-green-400: #76a9a9;
4242
--sf-toolbar-green-500: #598e8e;
4343
--sf-toolbar-green-600: #436c6c;
4444
--sf-toolbar-green-700: #2e4949;
@@ -280,8 +280,8 @@ div.sf-toolbar .sf-toolbar-block .sf-toolbar-info-piece.sf-toolbar-info-php-ext
280280

281281
.sf-toolbar-block .sf-toolbar-status.sf-toolbar-status-green,
282282
.sf-toolbar-block .sf-toolbar-info .sf-toolbar-status.sf-toolbar-status-green {
283-
background-color: var(--sf-toolbar-green-400);
284-
color: var(--sf-toolbar-green-50);
283+
background-color: #059669;
284+
color: var(--white);
285285
}
286286
.sf-toolbar-block .sf-toolbar-status.sf-toolbar-status-red,
287287
.sf-toolbar-block .sf-toolbar-info .sf-toolbar-status.sf-toolbar-status-red {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.