Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2b34f2b

Browse filesBrowse files
committed
minor #28871 [Validator] use constraint options instead of properties (xabbuh)
This PR was merged into the 4.2-dev branch. Discussion ---------- [Validator] use constraint options instead of properties | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | For other constraints we always talk about "options" and that's how we name them in the documentation too. I think we should be consistent about the terminology being used here. What do you think? Commits ------- f642355 use constraint options instead of properties
2 parents 5e90b4a + f642355 commit 2b34f2b
Copy full SHA for 2b34f2b

File tree

Expand file treeCollapse file tree

3 files changed

+4
-4
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+4
-4
lines changed

‎UPGRADE-4.2.md

Copy file name to clipboardExpand all lines: UPGRADE-4.2.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ TwigBundle
261261
Validator
262262
---------
263263

264-
* The `checkMX` and `checkHost` properties of the Email constraint are deprecated
264+
* The `checkMX` and `checkHost` options of the `Email` constraint are deprecated
265265
* The component is now decoupled from `symfony/translation` and uses `Symfony\Contracts\Translation\TranslatorInterface` instead
266266
* The `ValidatorBuilderInterface` has been deprecated and `ValidatorBuilder` made final
267267
* Deprecated validating instances of `\DateTimeInterface` in `DateTimeValidator`, `DateValidator` and `TimeValidator`. Use `Type` instead or remove the constraint if the underlying model is type hinted to `\DateTimeInterface` already.

‎UPGRADE-5.0.md

Copy file name to clipboardExpand all lines: UPGRADE-5.0.md
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ TwigBundle
254254
Validator
255255
--------
256256

257-
* The `checkMX` and `checkHost` properties of the Email constraint were removed
257+
* The `checkMX` and `checkHost` options of the `Email` constraint were removed
258258
* The `Email::__construct()` 'strict' property has been removed. Use 'mode'=>"strict" instead.
259259
* Calling `EmailValidator::__construct()` method with a boolean parameter has been removed, use `EmailValidator("strict")` instead.
260260
* Removed the `checkDNS` and `dnsMessage` options from the `Url` constraint.

‎src/Symfony/Component/Validator/Constraints/Email.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Validator/Constraints/Email.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,11 @@ public function __construct($options = null)
8181
}
8282

8383
if (\is_array($options) && array_key_exists('checkMX', $options)) {
84-
@trigger_error('The "checkMX" property is deprecated since Symfony 4.2.', E_USER_DEPRECATED);
84+
@trigger_error('The "checkMX" option is deprecated since Symfony 4.2.', E_USER_DEPRECATED);
8585
}
8686

8787
if (\is_array($options) && array_key_exists('checkHost', $options)) {
88-
@trigger_error('The "checkHost" property is deprecated since Symfony 4.2.', E_USER_DEPRECATED);
88+
@trigger_error('The "checkHost" option is deprecated since Symfony 4.2.', E_USER_DEPRECATED);
8989
}
9090

9191
if (\is_array($options) && array_key_exists('mode', $options) && !\in_array($options['mode'], self::$validationModes, true)) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.