Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 28e502e

Browse filesBrowse files
bug #35134 [PropertyInfo] Fix BC issue in phpDoc Reflection library (jaapio)
This PR was merged into the 3.4 branch. Discussion ---------- [PropertyInfo] Fix BC issue in phpDoc Reflection library | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35077 | License | MIT The used phpDocumentor library DocBlockReflection contained a BC break that broke this component. The patch was applied in the recently released v4.3.4 version. But since it is unclear how long this issue existed it is not possible to exclude a certain version. Therefor also `\RuntimeExpception` needs to be caught. The BC break is possibly caused by a change in the TypeResolver library used by the DocBlockReflection which is now supporting the more popular generics notation for arrays. This PR might need some tests but the current test cases are not very clear to me. Instead of patching the code we could also try to ban the broken versions of the used phpdoc libraries, but that would require much more testing, and doesn't really add any value. Especially because the DocBlockReflection and TypeResolver are used by over half a million projects. It would raise more questions than just patching the behavior of the PropertyInfo component. We are sorry that this issue slipt through our QA pipeline. The linked issue already showed that the issue is now fixed by just doing a `composer update` but it is not very convenient to leave this known issue in symfony. Commits ------- bad07ec Fix BC issue in phpDoc Reflection library
2 parents 8c7b1c8 + bad07ec commit 28e502e
Copy full SHA for 28e502e

File tree

1 file changed

+4
-0
lines changed
Filter options

1 file changed

+4
-0
lines changed

‎src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/PropertyInfo/Extractor/PhpDocExtractor.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,8 @@ private function getDocBlockFromProperty($class, $property)
212212
return $this->docBlockFactory->create($reflectionProperty, $this->contextFactory->createFromReflector($reflectionProperty->getDeclaringClass()));
213213
} catch (\InvalidArgumentException $e) {
214214
return null;
215+
} catch (\RuntimeException $e) {
216+
return null;
215217
}
216218
}
217219

@@ -257,6 +259,8 @@ private function getDocBlockFromMethod($class, $ucFirstProperty, $type)
257259
return [$this->docBlockFactory->create($reflectionMethod, $this->contextFactory->createFromReflector($reflectionMethod)), $prefix];
258260
} catch (\InvalidArgumentException $e) {
259261
return null;
262+
} catch (\RuntimeException $e) {
263+
return null;
260264
}
261265
}
262266
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.