Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 28abb38

Browse filesBrowse files
committed
minor #27966 [FrameworkBundle] fixed brackets position in method calls (destillat)
This PR was submitted for the 3.2 branch but it was merged into the 3.4 branch instead (closes #27966). Discussion ---------- [FrameworkBundle] fixed brackets position in method calls | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Fixed wrong colons positions in hasDefinition method calls Commits ------- b5863bc [FrameworkBundle] fixed brackets position in method calls
2 parents 44ce4dd + b5863bc commit 28abb38
Copy full SHA for 28abb38

File tree

Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-6
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,8 @@ public function testWorkflows()
191191
{
192192
$container = $this->createContainerFromFile('workflows');
193193

194-
$this->assertTrue($container->hasDefinition('workflow.article', 'Workflow is registered as a service'));
195-
$this->assertTrue($container->hasDefinition('workflow.article.definition', 'Workflow definition is registered as a service'));
194+
$this->assertTrue($container->hasDefinition('workflow.article'), 'Workflow is registered as a service');
195+
$this->assertTrue($container->hasDefinition('workflow.article.definition'), 'Workflow definition is registered as a service');
196196

197197
$workflowDefinition = $container->getDefinition('workflow.article.definition');
198198

@@ -210,8 +210,8 @@ public function testWorkflows()
210210
);
211211
$this->assertSame(array('workflow.definition' => array(array('name' => 'article', 'type' => 'workflow', 'marking_store' => 'multiple_state'))), $workflowDefinition->getTags());
212212

213-
$this->assertTrue($container->hasDefinition('state_machine.pull_request', 'State machine is registered as a service'));
214-
$this->assertTrue($container->hasDefinition('state_machine.pull_request.definition', 'State machine definition is registered as a service'));
213+
$this->assertTrue($container->hasDefinition('state_machine.pull_request'), 'State machine is registered as a service');
214+
$this->assertTrue($container->hasDefinition('state_machine.pull_request.definition'), 'State machine definition is registered as a service');
215215
$this->assertCount(4, $workflowDefinition->getArgument(1));
216216
$this->assertSame('draft', $workflowDefinition->getArgument(2));
217217

@@ -293,8 +293,8 @@ public function testWorkflowMultipleTransitionsWithSameName()
293293
{
294294
$container = $this->createContainerFromFile('workflow_with_multiple_transitions_with_same_name');
295295

296-
$this->assertTrue($container->hasDefinition('workflow.article', 'Workflow is registered as a service'));
297-
$this->assertTrue($container->hasDefinition('workflow.article.definition', 'Workflow definition is registered as a service'));
296+
$this->assertTrue($container->hasDefinition('workflow.article'), 'Workflow is registered as a service');
297+
$this->assertTrue($container->hasDefinition('workflow.article.definition'), 'Workflow definition is registered as a service');
298298

299299
$workflowDefinition = $container->getDefinition('workflow.article.definition');
300300

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.