Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 27bc8d6

Browse filesBrowse files
fabpotfabpot
committed
bug #52978 [Webhook] [Framework] Added missing XML attribute in config XSD (TimoBakx)
This PR was merged into the 6.3 branch. Discussion ---------- [Webhook] [Framework] Added missing XML attribute in config XSD | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT The XML schema definition was missing the type attribute for the webhook routing. This attribute is necessary to identify the correct parser and remote event consumers. In YAML and PHP, it exists and works: ```yaml framework: webhook: routing: mailer: # <-- this identifier service: #... secret: #... ``` ```php use App\Webhook\MailerWebhookParser; use Symfony\Config\FrameworkConfig; return static function (FrameworkConfig $frameworkConfig): void { $webhookConfig = $frameworkConfig->webhook(); $webhookConfig ->routing('mailer') // <-- this parameter ->service('mailer.webhook.request_parser.mailgun') ->secret('%env(MAILER_MAILGUN_SECRET)%') ; }; ``` #SymfonyHackday Commits ------- 43b0877 [Webhook] Added missing XML attribute in config XSD
2 parents 83b5c67 + 43b0877 commit 27bc8d6
Copy full SHA for 27bc8d6

File tree

1 file changed

+1
-0
lines changed
Filter options

1 file changed

+1
-0
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -976,6 +976,7 @@
976976
<xsd:element name="service" type="xsd:string" minOccurs="0" maxOccurs="1" />
977977
<xsd:element name="secret" type="xsd:string" minOccurs="0" maxOccurs="1" />
978978
</xsd:sequence>
979+
<xsd:attribute name="type" type="xsd:string" use="required" />
979980
</xsd:complexType>
980981

981982
<xsd:complexType name="remote-event">

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.