Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 277219d

Browse filesBrowse files
minor #25795 [HttpFoundation] fix HHVM tests (xabbuh)
This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] fix HHVM tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | | License | MIT | Doc PR | It looks like `parse_url()` broke for some URLs in HHVM 3.18.7. For our tests it IMO isn't really relevant how username and password look like. Commits ------- da21003 fix HHVM tests
2 parents 70c8c2d + da21003 commit 277219d
Copy full SHA for 277219d

File tree

1 file changed

+4
-4
lines changed
Filter options

1 file changed

+4
-4
lines changed

‎src/Symfony/Component/HttpFoundation/Tests/RequestTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,18 @@ public function testGetLocale()
4545

4646
public function testGetUser()
4747
{
48-
$request = Request::create('http://user_test:password_test@test.com/');
48+
$request = Request::create('http://user:password@test.com');
4949
$user = $request->getUser();
5050

51-
$this->assertEquals('user_test', $user);
51+
$this->assertEquals('user', $user);
5252
}
5353

5454
public function testGetPassword()
5555
{
56-
$request = Request::create('http://user_test:password_test@test.com/');
56+
$request = Request::create('http://user:password@test.com');
5757
$password = $request->getPassword();
5858

59-
$this->assertEquals('password_test', $password);
59+
$this->assertEquals('password', $password);
6060
}
6161

6262
public function testIsNoCache()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.