Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 276335e

Browse filesBrowse files
committed
[FrameworkBundle] remove esi/ssi renderers if inactive
1 parent e77545a commit 276335e
Copy full SHA for 276335e

File tree

2 files changed

+20
-0
lines changed
Filter options

2 files changed

+20
-0
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,8 @@ private function registerFormConfiguration(array $config, ContainerBuilder $cont
213213
private function registerEsiConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
214214
{
215215
if (!$this->isConfigEnabled($container, $config)) {
216+
$container->removeDefinition('fragment.renderer.esi');
217+
216218
return;
217219
}
218220

@@ -222,6 +224,8 @@ private function registerEsiConfiguration(array $config, ContainerBuilder $conta
222224
private function registerSsiConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
223225
{
224226
if (!$this->isConfigEnabled($container, $config)) {
227+
$container->removeDefinition('fragment.renderer.ssi');
228+
225229
return;
226230
}
227231

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+16Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,29 @@ public function testEsi()
9898
$this->assertTrue($container->hasDefinition('esi'), '->registerEsiConfiguration() loads esi.xml');
9999
}
100100

101+
public function testEsiInactive()
102+
{
103+
$container = $this->createContainerFromFile('default_config');
104+
105+
$this->assertFalse($container->hasDefinition('fragment.renderer.esi'));
106+
$this->assertFalse($container->hasDefinition('esi'));
107+
}
108+
101109
public function testSsi()
102110
{
103111
$container = $this->createContainerFromFile('full');
104112

105113
$this->assertTrue($container->hasDefinition('ssi'), '->registerSsiConfiguration() loads ssi.xml');
106114
}
107115

116+
public function testSsiInactive()
117+
{
118+
$container = $this->createContainerFromFile('default_config');
119+
120+
$this->assertFalse($container->hasDefinition('fragment.renderer.ssi'));
121+
$this->assertFalse($container->hasDefinition('ssi'));
122+
}
123+
108124
public function testEnabledProfiler()
109125
{
110126
$container = $this->createContainerFromFile('profiler');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.