Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 26c2a85

Browse filesBrowse files
committed
bug #45174 [Notifier] Use the UTF-8 encoding in smsapi-notifier (marphi)
This PR was merged into the 5.3 branch. Discussion ---------- [Notifier] Use the UTF-8 encoding in smsapi-notifier | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | --- | License | MIT | Doc PR | --- THIS PR is splitted version of PR #45139 (see discussion) Currently smsapi-notifier does not specify encoding in payload request to provider api which generates such errors. ![image](https://user-images.githubusercontent.com/57309/151045363-a5b97e9a-94b5-4fba-b93a-76ab72a8bd5f.png) (sms message with invalid encoding) api.smsapi.pl use windows-1250 as a default value. I propose to set explicitly `utf-8`. After changes: ![Zrzut ekranu 2022-01-23 o 21 52 28](https://user-images.githubusercontent.com/57309/151045277-2c11b5c5-8b0f-4f1d-b749-2661a6443a4c.png) Commits ------- 7ad382d [Notifier] smsapi-notifier - correct encoding
2 parents eda8537 + 7ad382d commit 26c2a85
Copy full SHA for 26c2a85

File tree

1 file changed

+1
-0
lines changed
Filter options

1 file changed

+1
-0
lines changed

‎src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ protected function doSend(MessageInterface $message): SentMessage
6464
'to' => $message->getPhone(),
6565
'message' => $message->getSubject(),
6666
'format' => 'json',
67+
'encoding' => 'utf-8',
6768
],
6869
]);
6970

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.