Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 25c9cbe

Browse filesBrowse files
bug #58739 [WebProfilerBoundle] form data collector check passed and resolved options are defined (vltrof)
This PR was submitted for the 6.4 branch but it was merged into the 5.4 branch instead. Discussion ---------- [WebProfilerBoundle] form data collector check passed and resolved options are defined | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #58665 | License | MIT Greetings! When passed or resolved value casted to false (null/false) it sets wrong value what cause exceptions described in issue. Explicit check if value defined prevent this behavior Maybe codestyle should be fixed because of ternary Commits ------- 93faa96 profiler form data collector extart value property if it is setted
2 parents 5865f28 + 93faa96 commit 25c9cbe
Copy full SHA for 25c9cbe

File tree

Expand file treeCollapse file tree

1 file changed

+4
-2
lines changed
Filter options
  • src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector
Expand file treeCollapse file tree

1 file changed

+4
-2
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -650,8 +650,10 @@
650650
<td>{{ profiler_dump(value) }}</td>
651651
<td>
652652
{# values can be stubs #}
653-
{% set option_value = value.value|default(value) %}
654-
{% set resolved_option_value = data.resolved_options[option].value|default(data.resolved_options[option]) %}
653+
{% set option_value = (value.value is defined) ? value.value : value %}
654+
{% set resolved_option_value = (data.resolved_options[option].value is defined)
655+
? data.resolved_options[option].value
656+
: data.resolved_options[option] %}
655657
{% if resolved_option_value == option_value %}
656658
<em class="font-normal text-muted">same as passed value</em>
657659
{% else %}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.