Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2355715

Browse filesBrowse files
committed
Making cache rebuild correctly with MessageSubscriberInterface return values
1 parent 4f290d7 commit 2355715
Copy full SHA for 2355715

File tree

3 files changed

+34
-0
lines changed
Filter options

3 files changed

+34
-0
lines changed

‎src/Symfony/Component/Config/Resource/ReflectionClassResource.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Resource/ReflectionClassResource.php
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Symfony\Component\DependencyInjection\ServiceSubscriberInterface as LegacyServiceSubscriberInterface;
1515
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
16+
use Symfony\Component\Messenger\Handler\MessageSubscriberInterface;
1617
use Symfony\Contracts\Service\ServiceSubscriberInterface;
1718

1819
/**
@@ -158,6 +159,13 @@ private function generateSignature(\ReflectionClass $class)
158159
yield print_r($class->name::getSubscribedEvents(), true);
159160
}
160161

162+
if (interface_exists(MessageSubscriberInterface::class, false) && $class->isSubclassOf(MessageSubscriberInterface::class)) {
163+
yield MessageSubscriberInterface::class;
164+
foreach ($class->name::getHandledMessages() as $value) {
165+
yield print_r($value, true);
166+
}
167+
}
168+
161169
if (interface_exists(LegacyServiceSubscriberInterface::class, false) && $class->isSubclassOf(LegacyServiceSubscriberInterface::class)) {
162170
yield LegacyServiceSubscriberInterface::class;
163171
yield print_r([$class->name, 'getSubscribedServices'](), true);

‎src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php
+25Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
use Symfony\Component\Config\Resource\ReflectionClassResource;
1616
use Symfony\Component\DependencyInjection\ServiceSubscriberInterface;
1717
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
18+
use Symfony\Component\Messenger\Handler\MessageSubscriberInterface;
1819

1920
class ReflectionClassResourceTest extends TestCase
2021
{
@@ -147,6 +148,18 @@ public function testEventSubscriber()
147148
$this->assertTrue($res->isFresh(0));
148149
}
149150

151+
public function testMessageSubscriber()
152+
{
153+
$res = new ReflectionClassResource(new \ReflectionClass(TestMessageSubscriber::class));
154+
$this->assertTrue($res->isFresh(0));
155+
156+
TestMessageSubscriber::$subscribedMessages = ['SomeMessageClass'];
157+
$this->assertFalse($res->isFresh(0));
158+
159+
$res = new ReflectionClassResource(new \ReflectionClass(TestMessageSubscriber::class));
160+
$this->assertTrue($res->isFresh(0));
161+
}
162+
150163
public function testServiceSubscriber()
151164
{
152165
$res = new ReflectionClassResource(new \ReflectionClass(TestServiceSubscriber::class));
@@ -174,6 +187,18 @@ public static function getSubscribedEvents()
174187
}
175188
}
176189

190+
class TestMessageSubscriber implements MessageSubscriberInterface
191+
{
192+
public static $subscribedMessages = [];
193+
194+
public static function getHandledMessages(): iterable
195+
{
196+
foreach (self::$subscribedMessages as $subscribedMessage) {
197+
yield $subscribedMessage;
198+
}
199+
}
200+
}
201+
177202
class TestServiceSubscriber implements ServiceSubscriberInterface
178203
{
179204
public static $subscribedServices = [];

‎src/Symfony/Component/Config/composer.json

Copy file name to clipboardExpand all lines: src/Symfony/Component/Config/composer.json
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"symfony/dependency-injection": "~3.4|~4.0",
2525
"symfony/event-dispatcher": "~3.4|~4.0",
2626
"symfony/finder": "~3.4|~4.0",
27+
"symfony/messenger": "~4.1",
2728
"symfony/yaml": "~3.4|~4.0"
2829
},
2930
"conflict": {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.