Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2014e64

Browse filesBrowse files
committed
[RateLimiter] Fix results on last token consume.
1 parent 5f78910 commit 2014e64
Copy full SHA for 2014e64

File tree

Expand file treeCollapse file tree

2 files changed

+23
-1
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+23
-1
lines changed

‎src/Symfony/Component/RateLimiter/Policy/SlidingWindowLimiter.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/RateLimiter/Policy/SlidingWindowLimiter.php
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,14 @@ public function reserve(int $tokens = 1, ?float $maxTime = null): Reservation
7474
if ($availableTokens >= $tokens) {
7575
$window->add($tokens);
7676

77-
$reservation = new Reservation($now, new RateLimit($this->getAvailableTokens($window->getHitCount()), \DateTimeImmutable::createFromFormat('U', floor($now)), true, $this->limit));
77+
if ($availableTokens === $tokens) {
78+
$resetDuration = $window->calculateTimeForTokens($this->limit, $tokens);
79+
$retryAfter = $now + $resetDuration;
80+
} else {
81+
$retryAfter = $now;
82+
}
83+
84+
$reservation = new Reservation($now, new RateLimit($this->getAvailableTokens($window->getHitCount()), \DateTimeImmutable::createFromFormat('U', floor($retryAfter)), true, $this->limit));
7885
} else {
7986
$waitDuration = $window->calculateTimeForTokens($this->limit, $tokens);
8087

‎src/Symfony/Component/RateLimiter/Tests/Policy/SlidingWindowLimiterTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/RateLimiter/Tests/Policy/SlidingWindowLimiterTest.php
+15Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,21 @@ public function testWaitIntervalOnConsumeOverLimit()
7070
$this->assertTrue($limiter->consume()->isAccepted());
7171
}
7272

73+
public function testConsumeLastToken()
74+
{
75+
$limiter = $this->createLimiter();
76+
$limiter->reset();
77+
$limiter->consume(9);
78+
79+
$rateLimit = $limiter->consume(1);
80+
$this->assertSame(0, $rateLimit->getRemainingTokens());
81+
$this->assertTrue($rateLimit->isAccepted());
82+
$this->assertEquals(
83+
\DateTimeImmutable::createFromFormat('U', (string) floor(microtime(true) + 12 / 10)),
84+
$rateLimit->getRetryAfter()
85+
);
86+
}
87+
7388
public function testReserve()
7489
{
7590
$limiter = $this->createLimiter();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.