Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 1ef27a7

Browse filesBrowse files
ycerutoyceruto
committed
Rename tag attribute "name" by "alias"
1 parent 3cc4a70 commit 1ef27a7
Copy full SHA for 1ef27a7

File tree

4 files changed

+15
-15
lines changed
Filter options

4 files changed

+15
-15
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1511,8 +1511,8 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder
15111511
$transportDefinition = (new Definition(TransportInterface::class))
15121512
->setFactory(array(new Reference('messenger.transport_factory'), 'createTransport'))
15131513
->setArguments(array($transport['dsn'], $transport['options']))
1514-
->addTag('messenger.receiver', array('name' => $name))
1515-
->addTag('messenger.sender', array('name' => $name))
1514+
->addTag('messenger.receiver', array('alias' => $name))
1515+
->addTag('messenger.sender', array('alias' => $name))
15161516
;
15171517
$container->setDefinition('messenger.transport.'.$name, $transportDefinition);
15181518
}

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -539,8 +539,8 @@ public function testMessengerTransports()
539539
$this->assertTrue($container->hasDefinition('messenger.transport.default'));
540540
$this->assertTrue($container->getDefinition('messenger.transport.default')->hasTag('messenger.receiver'));
541541
$this->assertTrue($container->getDefinition('messenger.transport.default')->hasTag('messenger.sender'));
542-
$this->assertEquals(array(array('name' => 'default')), $container->getDefinition('messenger.transport.default')->getTag('messenger.receiver'));
543-
$this->assertEquals(array(array('name' => 'default')), $container->getDefinition('messenger.transport.default')->getTag('messenger.sender'));
542+
$this->assertEquals(array(array('alias' => 'default')), $container->getDefinition('messenger.transport.default')->getTag('messenger.receiver'));
543+
$this->assertEquals(array(array('alias' => 'default')), $container->getDefinition('messenger.transport.default')->getTag('messenger.sender'));
544544

545545
$this->assertTrue($container->hasDefinition('messenger.transport.customised'));
546546
$transportFactory = $container->getDefinition('messenger.transport.customised')->getFactory();

‎src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function process(ContainerBuilder $container)
6363
}
6464

6565
if ($container->hasDefinition('messenger.data_collector')) {
66-
$this->registerBusToCollector($container, $busId, $tags[0]);
66+
$this->registerBusToCollector($container, $busId);
6767
}
6868
}
6969

@@ -177,8 +177,8 @@ private function registerReceivers(ContainerBuilder $container)
177177
$receiverMapping[$id] = new Reference($id);
178178

179179
foreach ($tags as $tag) {
180-
if (isset($tag['name'])) {
181-
$receiverMapping[$tag['name']] = $receiverMapping[$id];
180+
if (isset($tag['alias'])) {
181+
$receiverMapping[$tag['alias']] = $receiverMapping[$id];
182182
}
183183
}
184184
}
@@ -202,16 +202,16 @@ private function registerSenders(ContainerBuilder $container)
202202
$senderLocatorMapping[$id] = new Reference($id);
203203

204204
foreach ($tags as $tag) {
205-
if (isset($tag['name'])) {
206-
$senderLocatorMapping[$tag['name']] = $senderLocatorMapping[$id];
205+
if (isset($tag['alias'])) {
206+
$senderLocatorMapping[$tag['alias']] = $senderLocatorMapping[$id];
207207
}
208208
}
209209
}
210210

211211
$container->getDefinition('messenger.sender_locator')->replaceArgument(0, $senderLocatorMapping);
212212
}
213213

214-
private function registerBusToCollector(ContainerBuilder $container, string $busId, array $tag)
214+
private function registerBusToCollector(ContainerBuilder $container, string $busId)
215215
{
216216
$container->setDefinition(
217217
$tracedBusId = 'debug.traced.'.$busId,

‎src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
+5-5Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public function testGetClassesFromTheHandlerSubscriberInterface()
101101
public function testItRegistersReceivers()
102102
{
103103
$container = $this->getContainerBuilder();
104-
$container->register(AmqpReceiver::class, AmqpReceiver::class)->addTag('messenger.receiver', array('name' => 'amqp'));
104+
$container->register(AmqpReceiver::class, AmqpReceiver::class)->addTag('messenger.receiver', array('alias' => 'amqp'));
105105

106106
(new MessengerPass())->process($container);
107107

@@ -128,7 +128,7 @@ public function testItRegistersOneReceiverAndSetsTheDefaultOneOnTheCommand()
128128
null,
129129
));
130130

131-
$container->register(AmqpReceiver::class, AmqpReceiver::class)->addTag('messenger.receiver', array('name' => 'amqp'));
131+
$container->register(AmqpReceiver::class, AmqpReceiver::class)->addTag('messenger.receiver', array('alias' => 'amqp'));
132132

133133
(new MessengerPass())->process($container);
134134

@@ -145,8 +145,8 @@ public function testItRegistersMultipleReceiversAndDoesNotSetTheDefaultOneOnTheC
145145
null,
146146
));
147147

148-
$container->register(AmqpReceiver::class, AmqpReceiver::class)->addTag('messenger.receiver', array('name' => 'amqp'));
149-
$container->register(DummyReceiver::class, DummyReceiver::class)->addTag('messenger.receiver', array('name' => 'dummy'));
148+
$container->register(AmqpReceiver::class, AmqpReceiver::class)->addTag('messenger.receiver', array('alias' => 'amqp'));
149+
$container->register(DummyReceiver::class, DummyReceiver::class)->addTag('messenger.receiver', array('alias' => 'dummy'));
150150

151151
(new MessengerPass())->process($container);
152152

@@ -156,7 +156,7 @@ public function testItRegistersMultipleReceiversAndDoesNotSetTheDefaultOneOnTheC
156156
public function testItRegistersSenders()
157157
{
158158
$container = $this->getContainerBuilder();
159-
$container->register(AmqpSender::class, AmqpSender::class)->addTag('messenger.sender', array('name' => 'amqp'));
159+
$container->register(AmqpSender::class, AmqpSender::class)->addTag('messenger.sender', array('alias' => 'amqp'));
160160

161161
(new MessengerPass())->process($container);
162162

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.